Skip to content

feat: Support to pass image credentials #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Conversation

aatreyee2506
Copy link
Contributor

@aatreyee2506 aatreyee2506 commented Apr 21, 2025

Description

Added support to pass image credentials when pulling kibana image from a private registry.
Git_issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Added support for passing image pull credentials when deploying Kibana from a private registry, along with tests for the same.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506 aatreyee2506 changed the title ADD: Support to pass image credentials Add: Support to pass image credentials Apr 21, 2025
@aatreyee2506 aatreyee2506 marked this pull request as ready for review April 21, 2025 08:15
@aatreyee2506
Copy link
Contributor Author

Case 1:
with image-secret:
Screenshot 2025-04-21 at 1 39 02 PM

Case 2:
without image-secret:
Screenshot 2025-04-18 at 5 10 35 PM

@aatreyee2506 aatreyee2506 changed the title Add: Support to pass image credentials chore: Support to pass image credentials Apr 21, 2025
@aatreyee2506 aatreyee2506 changed the title chore: Support to pass image credentials feat: Support to pass image credentials Apr 21, 2025
@Ak-sky
Copy link
Member

Ak-sky commented Apr 21, 2025

Case 1: with image-secret: Screenshot 2025-04-21 at 1 39 02 PM

Case 2: without image-secret: Screenshot 2025-04-18 at 5 10 35 PM

I am seeing docker pull command, why are we doing this? This should be done by TF when setting credentials for the TF to pull the Kibana image.

@Ak-sky
Copy link
Member

Ak-sky commented Apr 21, 2025

@aatreyee2506 , Also are we allowed to use docker?

@Ak-sky
Copy link
Member

Ak-sky commented Apr 24, 2025

@aatreyee2506 , Also are we allowed to use docker?

Ok we can use Docker engine and not docker desktop.

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506 aatreyee2506 marked this pull request as draft May 8, 2025 08:17
@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee257
Copy link

/run pipeline

@aatreyee257 aatreyee257 marked this pull request as ready for review June 4, 2025 07:03
@aatreyee257
Copy link

/run pipeline

@aatreyee257
Copy link

/run pipeline

@aatreyee257 aatreyee257 requested a review from Ak-sky June 24, 2025 08:13
whoffler and others added 3 commits July 2, 2025 17:01
BREAKING CHANGE: There is no supported upgrade path from `standard` to the new `Fully configurable` or `Security-enforced` DA variations
@aatreyee257
Copy link

/run pipeline

@shemau
Copy link
Contributor

shemau commented Jul 4, 2025

/run pipeline

@shemau
Copy link
Contributor

shemau commented Jul 4, 2025

/run pipeline

@aatreyee257
Copy link

/run pipeline

@aatreyee257 aatreyee257 self-assigned this Jul 6, 2025
@aatreyee257
Copy link

/run pipeline

@aatreyee257
Copy link

/run pipeline

@aatreyee257
Copy link

/run pipeline

@aatreyee257
Copy link

/run pipeline

@aatreyee257 aatreyee257 requested a review from shemau July 15, 2025 08:52
@daniel-butler-irl
Copy link
Contributor

@aatreyee2506 Since there is no test for this (@ocofaigh do you think one is needed?), can you confirm you deployed this and it all works as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants