-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Support to pass image credentials #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/run pipeline |
@aatreyee2506 , Also are we allowed to use docker? |
Ok we can use Docker engine and not docker desktop. |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
BREAKING CHANGE: There is no supported upgrade path from `standard` to the new `Fully configurable` or `Security-enforced` DA variations
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
@aatreyee2506 Since there is no test for this (@ocofaigh do you think one is needed?), can you confirm you deployed this and it all works as expected? |
Description
Added support to pass image credentials when pulling kibana image from a private registry.
Git_issue
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Added support for passing image pull credentials when deploying Kibana from a private registry, along with tests for the same.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers