-
Notifications
You must be signed in to change notification settings - Fork 3
Addon dependency config for elasticsearch #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ibm_catalog.json
Outdated
"reference_version": true | ||
} | ||
], | ||
"version": "v1.10.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you supposed to pinpoint the version? I know we were doing this for Core PaaS (and surround too), but not sure if that's applicable to ICD modules too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be careful here because SCC-WP and App Config will have their own dependencies, and we need to ensure we lock to the same versions they are locked to when adding the same dependencies to this DA (eg KP, Observability, SM etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to catch such mismatched version we should add the addons testing in this same PR. See Key Protect or Observability tests for reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If adding addons (dependencies) please add them all in single PR (security / observability etc)
This will need rebasing on #181 when it is merged to get the tests to pass. |
015fd67
to
4f4a788
Compare
ce1d29d
to
8919e35
Compare
/run pipeline |
3 similar comments
/run pipeline |
/run pipeline |
/run pipeline |
f8270d6
to
b5e106a
Compare
/run pipeline |
/run pipeline |
/run pipeline |
Description
for issue - https://github.ibm.com/GoldenEye/issues/issues/13577
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers