Skip to content

Addon dependency config for elasticsearch #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

whoffler
Copy link
Contributor

@whoffler whoffler commented Jul 1, 2025

Description

for issue - https://github.ibm.com/GoldenEye/issues/issues/13577

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

ibm_catalog.json Outdated
"reference_version": true
}
],
"version": "v1.10.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you supposed to pinpoint the version? I know we were doing this for Core PaaS (and surround too), but not sure if that's applicable to ICD modules too.

Copy link
Contributor

@ocofaigh ocofaigh Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be careful here because SCC-WP and App Config will have their own dependencies, and we need to ensure we lock to the same versions they are locked to when adding the same dependencies to this DA (eg KP, Observability, SM etc)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to catch such mismatched version we should add the addons testing in this same PR. See Key Protect or Observability tests for reference

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If adding addons (dependencies) please add them all in single PR (security / observability etc)

@shemau
Copy link
Contributor

shemau commented Jul 1, 2025

This will need rebasing on #181 when it is merged to get the tests to pass.

@whoffler whoffler force-pushed the sccWorkloadProtectionDependency branch 6 times, most recently from 015fd67 to 4f4a788 Compare July 3, 2025 08:46
@whoffler whoffler changed the title Scc workload protection dependency Addon dependency config for elasticsearch Jul 4, 2025
@whoffler whoffler force-pushed the sccWorkloadProtectionDependency branch 3 times, most recently from ce1d29d to 8919e35 Compare July 7, 2025 13:38
@whoffler
Copy link
Contributor Author

whoffler commented Jul 7, 2025

/run pipeline

3 similar comments
@whoffler
Copy link
Contributor Author

whoffler commented Jul 7, 2025

/run pipeline

@whoffler
Copy link
Contributor Author

whoffler commented Jul 7, 2025

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler whoffler force-pushed the sccWorkloadProtectionDependency branch from f8270d6 to b5e106a Compare July 17, 2025 11:01
@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants