-
Notifications
You must be signed in to change notification settings - Fork 1
fix: do not create more than 1 assistant projects #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/run pipeline |
/run pipeline |
/run pipeline |
Conall's changes should be implemented - I will do the same for discovery scripts
/run pipeline |
…m-ibm-modules/terraform-ibm-rag-sample-da into create-single-assistant-project
/run pipeline |
/run pipeline |
/run pipeline |
curl --retry 3 -fLsS -X POST --location "$WATSON_ASSISTANT_URL/v2/assistants?version=2023-06-15" \ | ||
--header "Authorization: Bearer $token" \ | ||
--header "Content-Type: application/json" \ | ||
--data "{\"name\":\"gen-ai-rag-sample-app-assistant\",\"language\":\"en\",\"description\":\"Generative AI sample app assistant\"}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use project_name parameter here for the name
🎉 This PR is included in version 1.4.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
There was a bug in getting the assistant integration ID, as when you do terraform apply back to back it won't return assistant integration ID...
that's because if you apply multiple times it will create many projects - hence there will be more than 1 assistance ID...
But the script assumes only 1 assistant ID to be returned. I discussed with @brendankellyibm and it was concluded to restrict creating more than 1 project.
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers