Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide option to pass tags to module #8

Closed
vamsinm opened this issue Apr 19, 2023 · 2 comments
Closed

provide option to pass tags to module #8

vamsinm opened this issue Apr 19, 2023 · 2 comments

Comments

@vamsinm
Copy link
Contributor

vamsinm commented Apr 19, 2023

please provide option to pass tags to module so they can be populated on AWS Resouces created to meet organizational specific tagging requirements.

@arendej
Copy link
Contributor

arendej commented May 8, 2023

There are two paths at this time for AWS tags within our Terraform content for ROSA...

.1. any tags passed via the native AWS Terraform resources would be sent to those resources

.2a. any tags passed to ROSA cluster at creation time would be send to those resources

.2b. any tags passed day2(beyond cluster install) are not yet reconciled by ROSA/OpenShift, and this is pending a RFE in OpenShift upstream. Once we get that feature, we inherit it and it will be worked into our ROSA Terraform resources.

@arendej arendej closed this as completed May 8, 2023
@vamsinm
Copy link
Contributor Author

vamsinm commented May 9, 2023

@arendej Can you please elaborate a bit more on comments posted when closing the issue:

  1. any tags passed via the native AWS Terraform resources would be sent to those resources :
    how are these tags passed to these resources when i am using this terraform module?

2a. any tags passed via the native AWS Terraform resources would be sent to those resources:
if i create account roles or operator roles through this module and when i create a ROSA cluster and pass tags at the creation time, would that automatically update tags on account role and operator roles created through this module? in that case since account roles are created once, what happens when i build multiple clusters with different tags?

.2b. any tags passed day2(beyond cluster install) are not yet reconciled by ROSA/OpenShift, and this is pending a RFE in OpenShift upstream. Once we get that feature, we inherit it and it will be worked into our ROSA Terraform resources.
same question as 2a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants