Drift as a result of incorrect ARN lookup

[srlynch1]

This current code is causing continual drift as a result of using ephemeral ARN not the issuer_arn

terraform-rhcs-rosa-hcp/modules/rosa-cluster-hcp/main.tf

Line 25 in 078cd37

aws_account_arn = var.aws_account_arn == null ? data.aws_caller_identity.current[0].arn : var.aws_account_arn

This is using a value that is ephemeral or session based not the actual arn

aws_account_arn = var.aws_account_arn == null ? data.aws_caller_identity.current[0].arn : var.aws_account_arn

instead should use, this is example where this is handled correctly in the AWS EKS modules

data.aws_iam_session_context.current[0].issuer_arn

data "aws_iam_session_context" "current" {
  count = local.create ? 1 : 0
  arn = try(data.aws_caller_identity.current[0].arn, "")
}