Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance acceptance testing environment to enable resources in "extra" packages #353

Open
jlpedrosa opened this issue Feb 12, 2024 · 4 comments

Comments

@jlpedrosa
Copy link
Contributor

Hi team!

I was going to do a few PRs for the container resource. This is not on the base package so I have few questions.

Is it Ok from your perspective to add resources that are beyond the base package? ie: containers.
Is the Dev container ready with all the packages? if not should we added first? (assuming yes for the previous questions).

Happy coding!

@vaerh
Copy link
Collaborator

vaerh commented Feb 12, 2024

Hi!
The situation with container support hasn't changed since #86. I think it is possible to add container support, as there are already a number of resources that cannot be covered by tests. And things are not bad so far.
Also at the time of my research there was no way to automatically install packages into a ROS test container. So I don't have a way to automatically build the required test container configuration at the time of docker image generation or add packages later during test preparation.

@vaerh
Copy link
Collaborator

vaerh commented Feb 14, 2024

@jlpedrosa Can I close this issue?

@jlpedrosa jlpedrosa changed the title Design/Plan for resources in "extra" packages Enhance acceptance testing environment to enable resources in "extra" packages Feb 14, 2024
@jlpedrosa
Copy link
Contributor Author

@vaerh I've updated the description, to keep track of the depencency on extra packages if it makes sense. If you don't agree with the new approach, we can close it.

@vaerh
Copy link
Collaborator

vaerh commented Feb 15, 2024

No problem. Let it hang!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants