Block.p.percentBuPeak should replace Block.p.percentBuMax

[drewj-tp]

Talked with @onufer this morning on my confusion between Block.p.percentBuMax

armi/armi/reactor/blockParameters.py

Lines 139 to 145 in 864106e

	pb.defParam(
	"percentBuMax",
	units=units.PERCENT_FIMA,
	description="Maximum percentage in a single pin of the initial heavy metal "
	"atoms that have been fissioned",
	location=ParamLocation.MAX,
	)

and Block.p.percentBuPeak

armi/armi/reactor/blockParameters.py

Lines 796 to 802 in 864106e

	pb.defParam(
	"percentBuPeak",
	units=units.PERCENT_FIMA,
	description="Peak percentage of the initial heavy metal atoms that have been fissioned",
	location=ParamLocation.MAX,
	categories=["cumulative", "eq cumulative shift"],
	)

Looking at their metadata, they feel very similar and redundant. @onufer indicated the "peak" parameter is a bounding burnup that could supersede percentBuMax as the metric for "maximum burnup for something in this block"

If I'm understanding his summary, that seems like a good argument for removing Block.p.percentBuMax.

We should also add the depletion category to the Block.p.percentBuPeak categories so it can be tracked and reported w/ other depletion parameters

[albeanth]

This feels like a simple enough of a request that could be completed with #1990

[onufer]

yes we can remove max burnup if thats desired.

[drewj-tp]

yes we can remove max burnup if thats desired.

Okay. It's desired because we have two ways of defining the same concept right now, and that's not helpful for devs, analysts, users, anyone

[drewj-tp]

I'm going to fold this into the ongoing assembly rotation work (#1921) because the Block.p.percentBuMax and Block.p.percentBuMaxPinLocation parameters were only used for that feature

armi/armi/physics/fuelCycle/hexAssemblyFuelMgmtUtils.py

Line 83 in 864106e

_maxBuAssem, maxBuBlock = a.getMaxParam("percentBuMax", returnObj=True)