Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include support for Acoustic Echo Cancellation #81

Open
3 tasks done
benklop opened this issue Aug 29, 2024 · 0 comments
Open
3 tasks done

Include support for Acoustic Echo Cancellation #81

benklop opened this issue Aug 29, 2024 · 0 comments

Comments

@benklop
Copy link

benklop commented Aug 29, 2024

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

I have pulled in #77 to my local branch, and now am able to use full duplex audio. I in fact can play music from my Onju Voice, and still get responses from Assist running on the speaker. Unfortunately I have to either shout or put my face right up to the thing, because there is no echo cancellation right now.

Describe the solution you'd like

Ideally AEC could be enabled to cancel out the playback from the speaker and allow better recording while the media player is in use. This would probably require support in https://github.com/gnumpi/esphome_audio, and I can't find any evidence of discussion either here or there about adding this.

Is it possible to support this with the hardware in the Onju Voice? The original repo suggests it is possible.

Describe alternatives you've considered

Speaking loudly, pausing the speaker manually when trying to say the wake word

Additional context

https://github.com/justLV/onju-voice?tab=readme-ov-file#limitations-of-this-release suggests ESP-ADF and/or ESP-Skainet is needed for this. I think it's referring to https://docs.espressif.com/projects/esp-sr/en/latest/esp32/audio_front_end/README.html which has docs on using AEC, but it's unclear to me whether this is compatible with the way esphome_audio is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant