Skip to content

patterns aren't like tar #33

@codefromthecrypt

Description

@codefromthecrypt

Describe the bug
In tar, you can extract something by its base directory, while here you have to know the path containing files and use a glob.

To Reproduce

We can do this:

$ car --created-by-pattern='Application Slice: .*' -tvf springcloud/spring-cloud-kubernetes-discoveryserver:3.1.0 'workspace/META-INF/*'
-rw-r--r--	582	Jan  1 08:00:01	workspace/META-INF/MANIFEST.MF

but it won't get any subdirs, and also you can't just pass the subdir you want.

$ car --created-by-pattern='Application Slice: .*' -tvf springcloud/spring-cloud-kubernetes-discoveryserver:3.1.0 workspace/META-INF
error: workspace/META-INF not found in layer

Expected behavior

$ car --created-by-pattern='Application Slice: .*' -tvf springcloud/spring-cloud-kubernetes-discoveryserver:3.1.0 workspace/META-INF
-rw-r--r--	582	Jan  1 08:00:01	/workspace/META-INF/MANIFEST.MF
-rw-r--r--	99	Jan  1 08:00:01	/workspace/META-INF/maven/org.springframework.cloud/spring-cloud-kubernetes-discoveryserver/pom.properties
-rw-r--r--	3991	Jan  1 08:00:01	/workspace/META-INF/maven/org.springframework.cloud/spring-cloud-kubernetes-discoveryserver/pom.xml
-rw-r--r--	66	Jan  1 08:00:01	/workspace/META-INF/services/java.nio.file.spi.FileSystemProvider

Additional context

We probably don't need globbing, and should do normal tar-like path matching that works with either exact files or anything in a directory.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions