Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfinished MBC1 implementation causes out-of-bounds memory accesses #2

Open
tgsm opened this issue Sep 23, 2020 · 0 comments
Open

Unfinished MBC1 implementation causes out-of-bounds memory accesses #2

tgsm opened this issue Sep 23, 2020 · 0 comments
Labels
bug Something isn't working MBC Issue is caused by or has something to do with a Memory Bank Controller

Comments

@tgsm
Copy link
Owner

tgsm commented Sep 23, 2020

The last commit (5514971) added proper bounds-checking which exposed a bunch of out-of-bounds reads and writes which shouldn't have been made. We need to fix this by adding a proper MBC1 implementation.
@tgsm tgsm added bug Something isn't working MBC Issue is caused by or has something to do with a Memory Bank Controller labels Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working MBC Issue is caused by or has something to do with a Memory Bank Controller
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tgsm