Skip to content

Commit a6dd5d2

Browse files
committed
reducing verbosity on query creation, that part is not so important/
Signed-off-by: Pedro Tanaka <[email protected]>
1 parent 507bfe6 commit a6dd5d2

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

engine/engine.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -275,24 +275,18 @@ func (e *Engine) MakeInstantQuery(ctx context.Context, q storage.Queryable, opts
275275
DisableDuplicateLabelCheck: e.disableDuplicateLabelChecks,
276276
}
277277

278-
optimizeSpan := tracing.ChildSpan(span, "optimize_plan")
279278
lplan, warns := logicalplan.NewFromAST(expr, qOpts, planOpts).Optimize(e.getLogicalOptimizers(opts))
280-
optimizeSpan.Finish()
281279

282280
ctx = warnings.NewContext(ctx)
283281
defer func() { warns.Merge(warnings.FromContext(ctx)) }()
284282

285-
scannersSpan := tracing.ChildSpan(span, "create_storage_scanners")
286283
scanners, err := e.storageScanners(q, qOpts, lplan)
287-
scannersSpan.Finish()
288284
if err != nil {
289285
tracing.LogError(span, err)
290286
return nil, errors.Wrap(err, "creating storage scanners")
291287
}
292288

293-
execSpan := tracing.ChildSpan(span, "create_execution")
294289
exec, err := execution.New(ctx, lplan.Root(), scanners, qOpts)
295-
execSpan.Finish()
296290
if err != nil {
297291
tracing.LogError(span, err)
298292
return nil, err
@@ -396,24 +390,18 @@ func (e *Engine) MakeRangeQuery(ctx context.Context, q storage.Queryable, opts *
396390
DisableDuplicateLabelCheck: e.disableDuplicateLabelChecks,
397391
}
398392

399-
optimizeSpan := tracing.ChildSpan(span, "optimize_plan")
400393
lplan, warns := logicalplan.NewFromAST(expr, qOpts, planOpts).Optimize(e.getLogicalOptimizers(opts))
401-
optimizeSpan.Finish()
402394

403395
ctx = warnings.NewContext(ctx)
404396
defer func() { warns.Merge(warnings.FromContext(ctx)) }()
405397

406-
scannersSpan := tracing.ChildSpan(span, "create_storage_scanners")
407398
scnrs, err := e.storageScanners(q, qOpts, lplan)
408-
scannersSpan.Finish()
409399
if err != nil {
410400
tracing.LogError(span, err)
411401
return nil, errors.Wrap(err, "creating storage scanners")
412402
}
413403

414-
execSpan := tracing.ChildSpan(span, "create_execution")
415404
exec, err := execution.New(ctx, lplan.Root(), scnrs, qOpts)
416-
execSpan.Finish()
417405
if err != nil {
418406
tracing.LogError(span, err)
419407
return nil, err

0 commit comments

Comments
 (0)