You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Emit error when querying native histograms with extended functions (#322)
* Emit error when querying native histograms with extended functions
We saw panics on our setup because users tried to use the extended functions with native histograms, which led to rates calculated with only one sample in some windows.
In this PR I am introducing a safeguard against this type of situation and emiting a warn when users try to query native histograms with extended functions.
Signed-off-by: Pedro Tanaka <[email protected]>
Fixing test case
Signed-off-by: Pedro Tanaka <[email protected]>
removing dead code
Signed-off-by: Pedro Tanaka <[email protected]>
Return error instead of warn
Signed-off-by: Pedro Tanaka <[email protected]>
fixing linting
Signed-off-by: Pedro Tanaka <[email protected]>
* Update execution/scan/functions.go
Co-authored-by: Filip Petkovski <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
* Removing query context
Signed-off-by: Pedro Tanaka <[email protected]>
---------
Signed-off-by: Pedro Tanaka <[email protected]>
Co-authored-by: Filip Petkovski <[email protected]>
0 commit comments