-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support query stats #148
Comments
Since this query engine is different from the old engine in terms of the query execution stages, I feel we don't have to support query timings for now. But it would be nice to support query samples first. |
Can we solve this through #106 ? |
I think #106 has a larger scope than this one. |
Got it, makes sense. |
I would like to contribute to adding support for query stats in the engine. |
The original promql engine has builtin support for query stats https://github.com/prometheus/prometheus/blob/main/util/stats/query_stats.go#L112.
It has mainly 2 parts: timings and samples.
It would be nice to support capturing those stats in this query engine.
The text was updated successfully, but these errors were encountered: