Fix svg map display in Firefox #1158

Razzmatazzz · 2025-10-16T17:54:19Z

Changes the way svg maps are handled so that they don't become out of position on Firefox.
Before (notice how the locks on the left don't align with the walls/doorways):

After:

This PR also:

Moves the player position market from Misc to Landmarks in the legend
Removes the site footer from the map page, which prevents the map from getting out of frame.
Removes the 10px left and right margins from the main content portion of the map page to maximize the area available for displaying the map

Resolves #1152

github-actions · 2025-10-16T17:54:31Z

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

👀 Observe the CI jobs and tests to ensure they are passing
✔️ Obtain an approval/review on this pull request
🚀 Deploy your pull request to the development environment with .deploy to development
🚀 Deploy your pull request to the production environment with .deploy

If anything goes wrong, rollback with .deploy main
🎉 Merge!

Note: If you have a larger change and want to block deployments, you can run .lock --reason <reason> to lock all other deployments (remove with .unlock)

You can view the branch deploy usage guide for additional information

Razzmatazzz · 2025-10-16T17:56:13Z

.deploy to development

github-actions · 2025-10-16T17:56:27Z

⚠️ Cannot proceed with deployment

Your pull request is in a draft state

Razzmatazzz · 2025-10-16T17:56:46Z

.deploy to development

github-actions · 2025-10-16T17:57:02Z

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to development (branch: fix-map-svgs)

You can watch the progress here 🔗

Details

{
  "type": "branch",
  "environment": {
    "name": "development",
    "url": null
  },
  "deployment": {
    "timestamp": "2025-10-16T17:57:02.559Z",
    "logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/18570249414"
  },
  "git": {
    "branch": "fix-map-svgs",
    "commit": "bc817be1b3e39b0a413aa311f1f09f355ca50763",
    "verified": false,
    "committer": "Razzmatazzz",
    "html_url": "https://github.com/the-hideout/tarkov-dev/commit/bc817be1b3e39b0a413aa311f1f09f355ca50763"
  },
  "context": {
    "actor": "Razzmatazzz",
    "noop": false,
    "fork": false,
    "comment": {
      "created_at": "2025-10-16T17:56:46Z",
      "updated_at": "2025-10-16T17:56:46Z",
      "body": ".deploy to development",
      "html_url": "https://github.com/the-hideout/tarkov-dev/pull/1158#issuecomment-3412120743"
    }
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

github-actions · 2025-10-16T17:59:00Z

Deployment Results ✅

Razzmatazzz successfully deployed branch fix-map-svgs to development

Show Results

https://6a9e5ac2.tarkov-dev.pages.dev

Details

{
  "status": "success",
  "environment": {
    "name": "development",
    "url": null
  },
  "deployment": {
    "id": 3161971005,
    "timestamp": "2025-10-16T17:58:59.765Z",
    "logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/18570249414",
    "duration": 117
  },
  "git": {
    "branch": "fix-map-svgs",
    "commit": "bc817be1b3e39b0a413aa311f1f09f355ca50763",
    "verified": false
  },
  "context": {
    "actor": "Razzmatazzz",
    "noop": false,
    "fork": false
  },
  "reviews": {
    "count": 0,
    "decision": "REVIEW_REQUIRED"
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

The merge-base changed after approval.

Razzmatazzz · 2025-10-17T10:59:12Z

.deploy

github-actions · 2025-10-17T10:59:31Z

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production (branch: fix-map-svgs)

You can watch the progress here 🔗

Details

{
  "type": "branch",
  "environment": {
    "name": "production",
    "url": "https://tarkov.dev"
  },
  "deployment": {
    "timestamp": "2025-10-17T10:59:31.420Z",
    "logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/18590645598"
  },
  "git": {
    "branch": "fix-map-svgs",
    "commit": "d9dfc67c08b2510e89fed92dbdae298f3424d5e2",
    "verified": true,
    "committer": "web-flow",
    "html_url": "https://github.com/the-hideout/tarkov-dev/commit/d9dfc67c08b2510e89fed92dbdae298f3424d5e2"
  },
  "context": {
    "actor": "Razzmatazzz",
    "noop": false,
    "fork": false,
    "comment": {
      "created_at": "2025-10-17T10:59:12Z",
      "updated_at": "2025-10-17T10:59:12Z",
      "body": ".deploy",
      "html_url": "https://github.com/the-hideout/tarkov-dev/pull/1158#issuecomment-3414997900"
    }
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

github-actions · 2025-10-17T11:01:26Z

Deployment Results ✅

Razzmatazzz successfully deployed branch fix-map-svgs to production

Details

{
  "status": "success",
  "environment": {
    "name": "production",
    "url": "https://tarkov.dev"
  },
  "deployment": {
    "id": 3165626376,
    "timestamp": "2025-10-17T11:01:26.519Z",
    "logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/18590645598",
    "duration": 115
  },
  "git": {
    "branch": "fix-map-svgs",
    "commit": "d9dfc67c08b2510e89fed92dbdae298f3424d5e2",
    "verified": true
  },
  "context": {
    "actor": "Razzmatazzz",
    "noop": false,
    "fork": false
  },
  "reviews": {
    "count": 0,
    "decision": "REVIEW_REQUIRED"
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

Environment URL: tarkov.dev

Razzmatazzz · 2025-10-17T20:10:40Z

.deploy

github-actions · 2025-10-17T20:10:55Z

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production (branch: fix-map-svgs)

You can watch the progress here 🔗

Details

{
  "type": "branch",
  "environment": {
    "name": "production",
    "url": "https://tarkov.dev"
  },
  "deployment": {
    "timestamp": "2025-10-17T20:10:54.895Z",
    "logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/18603690036"
  },
  "git": {
    "branch": "fix-map-svgs",
    "commit": "68504eb263279b04a40341f16f2d7e7992cb8559",
    "verified": false,
    "committer": "Razzmatazzz",
    "html_url": "https://github.com/the-hideout/tarkov-dev/commit/68504eb263279b04a40341f16f2d7e7992cb8559"
  },
  "context": {
    "actor": "Razzmatazzz",
    "noop": false,
    "fork": false,
    "comment": {
      "created_at": "2025-10-17T20:10:40Z",
      "updated_at": "2025-10-17T20:10:40Z",
      "body": ".deploy",
      "html_url": "https://github.com/the-hideout/tarkov-dev/pull/1158#issuecomment-3416949395"
    }
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

github-actions · 2025-10-17T20:12:59Z

Deployment Results ✅

Razzmatazzz successfully deployed branch fix-map-svgs to production

Details

{
  "status": "success",
  "environment": {
    "name": "production",
    "url": "https://tarkov.dev"
  },
  "deployment": {
    "id": 3168227252,
    "timestamp": "2025-10-17T20:12:58.904Z",
    "logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/18603690036",
    "duration": 124
  },
  "git": {
    "branch": "fix-map-svgs",
    "commit": "68504eb263279b04a40341f16f2d7e7992cb8559",
    "verified": false
  },
  "context": {
    "actor": "Razzmatazzz",
    "noop": false,
    "fork": false
  },
  "reviews": {
    "count": 0,
    "decision": "REVIEW_REQUIRED"
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

Environment URL: tarkov.dev

Razzmatazzz · 2025-10-17T20:19:35Z

.deploy

github-actions · 2025-10-17T20:19:50Z

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production (branch: fix-map-svgs)

You can watch the progress here 🔗

Details

{
  "type": "branch",
  "environment": {
    "name": "production",
    "url": "https://tarkov.dev"
  },
  "deployment": {
    "timestamp": "2025-10-17T20:19:50.444Z",
    "logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/18603886890"
  },
  "git": {
    "branch": "fix-map-svgs",
    "commit": "744ed30c803d25bdfbe947dbbc26cc9fb51f8ca4",
    "verified": false,
    "committer": "Razzmatazzz",
    "html_url": "https://github.com/the-hideout/tarkov-dev/commit/744ed30c803d25bdfbe947dbbc26cc9fb51f8ca4"
  },
  "context": {
    "actor": "Razzmatazzz",
    "noop": false,
    "fork": false,
    "comment": {
      "created_at": "2025-10-17T20:19:35Z",
      "updated_at": "2025-10-17T20:19:35Z",
      "body": ".deploy",
      "html_url": "https://github.com/the-hideout/tarkov-dev/pull/1158#issuecomment-3416974145"
    }
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

github-actions · 2025-10-17T20:21:53Z

Deployment Results ✅

Razzmatazzz successfully deployed branch fix-map-svgs to production

Details

{
  "status": "success",
  "environment": {
    "name": "production",
    "url": "https://tarkov.dev"
  },
  "deployment": {
    "id": 3168262790,
    "timestamp": "2025-10-17T20:21:53.055Z",
    "logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/18603886890",
    "duration": 123
  },
  "git": {
    "branch": "fix-map-svgs",
    "commit": "744ed30c803d25bdfbe947dbbc26cc9fb51f8ca4",
    "verified": false
  },
  "context": {
    "actor": "Razzmatazzz",
    "noop": false,
    "fork": false
  },
  "reviews": {
    "count": 0,
    "decision": "REVIEW_REQUIRED"
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

Environment URL: tarkov.dev

fix display of svg maps in Firefox

bc817be

Razzmatazzz marked this pull request as ready for review October 16, 2025 17:56

Razzmatazzz requested a review from a team as a code owner October 16, 2025 17:56

github-actions bot deployed to development October 16, 2025 17:57 Active

move player position to Landmarks group

f291aa0

GrantBirki previously approved these changes Oct 16, 2025

View reviewed changes

Merge branch 'main' into fix-map-svgs

d9dfc67

github-actions bot temporarily deployed to production October 17, 2025 10:59 Inactive

disable site footer on map page

68504eb

github-actions bot temporarily deployed to production October 17, 2025 20:10 Inactive

remove margins from map page

744ed30

github-actions bot deployed to production October 17, 2025 20:19 View deployment

Uh oh!

Fix svg map display in Firefox #1158

Are you sure you want to change the base?

Fix svg map display in Firefox #1158

Uh oh!

Conversation

Razzmatazzz commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 16, 2025

👋 Thanks for opening a pull request!

Uh oh!

Razzmatazzz commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

⚠️ Cannot proceed with deployment

Uh oh!

Razzmatazzz commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Deployment Triggered 🚀

Uh oh!

github-actions bot commented Oct 16, 2025

Deployment Results ✅

Uh oh!

Razzmatazzz commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Deployment Triggered 🚀

Uh oh!

github-actions bot commented Oct 17, 2025

Deployment Results ✅

Uh oh!

Razzmatazzz commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Deployment Triggered 🚀

Uh oh!

github-actions bot commented Oct 17, 2025

Deployment Results ✅

Uh oh!

Razzmatazzz commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Deployment Triggered 🚀

Uh oh!

github-actions bot commented Oct 17, 2025

Deployment Results ✅

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Razzmatazzz commented Oct 16, 2025 •

edited

Loading