Merge pull request #8 from the-ress/add-ci

Add GH actions and bump version

Author: the-ress

.github/workflows/ci.yml

@@ -0,0 +1,37 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  windows:
+    name: Windows
+    runs-on: windows-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+      - run: npm ci
+      - run: npm test
+
+  linux:
+    name: Linux
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+      - run: npm ci
+      - run: npm test
+
+  macos:
+    name: macOS
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+      - run: npm ci
+      - run: npm test

.github/workflows/publish.yml

@@ -0,0 +1,20 @@
+name: Publish to NPM
+
+on:
+  release:
+    types: [released]
+
+jobs:
+  publish:
+    name: Publish
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+          registry-url: "https://registry.npmjs.org"
+      - run: npm ci
+      - run: npm publish
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

README.md

@@ -20,8 +20,7 @@ console.log(allowSetForegroundWindow()) // all processes will be enabled to set
 
 ## Developing
  * `npm install -g node-gyp`
- * `node-gyp configure`
- * `node-gyp build`
+ * `npm install`
  * `npm test`
 
 ## Resources

package.json

@@ -1,9 +1,9 @@
 {
   "name": "windows-foreground-love",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "description": "API wrapper for AllowSetForegroundWindow",
   "main": "index.js",
-  "types": "index.d.ts",
+  "typings": "index.d.ts",
   "files": [
     "src",
     "binding.gyp",

src/common.h

@@ -0,0 +1,92 @@
+// """
+// Copyright Node.js contributors. All rights reserved.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to
+// deal in the Software without restriction, including without limitation the
+// rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+// sell copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+// IN THE SOFTWARE.
+// """
+
+// Empty value so that macros here are able to return NULL or void
+#define NAPI_RETVAL_NOTHING  // Intentionally blank #define
+
+#define GET_AND_THROW_LAST_ERROR(env)                                    \
+  do {                                                                   \
+    const napi_extended_error_info *error_info;                          \
+    napi_get_last_error_info((env), &error_info);                        \
+    bool is_pending;                                                     \
+    napi_is_exception_pending((env), &is_pending);                       \
+    /* If an exception is already pending, don't rethrow it */           \
+    if (!is_pending) {                                                   \
+      const char* error_message = error_info->error_message != NULL ?    \
+        error_info->error_message :                                      \
+        "empty error message";                                           \
+      napi_throw_error((env), NULL, error_message);                      \
+    }                                                                    \
+  } while (0)
+
+#define NAPI_ASSERT_BASE(env, assertion, message, ret_val)               \
+  do {                                                                   \
+    if (!(assertion)) {                                                  \
+      napi_throw_error(                                                  \
+          (env),                                                         \
+        NULL,                                                            \
+          "assertion (" #assertion ") failed: " message);                \
+      return ret_val;                                                    \
+    }                                                                    \
+  } while (0)
+
+// Returns NULL on failed assertion.
+// This is meant to be used inside napi_callback methods.
+#define NAPI_ASSERT(env, assertion, message)                             \
+  NAPI_ASSERT_BASE(env, assertion, message, NULL)
+
+// Returns empty on failed assertion.
+// This is meant to be used inside functions with void return type.
+#define NAPI_ASSERT_RETURN_VOID(env, assertion, message)                 \
+  NAPI_ASSERT_BASE(env, assertion, message, NAPI_RETVAL_NOTHING)
+
+#define NAPI_CALL_BASE(env, the_call, ret_val)                           \
+  do {                                                                   \
+    if ((the_call) != napi_ok) {                                         \
+      GET_AND_THROW_LAST_ERROR((env));                                   \
+      return ret_val;                                                    \
+    }                                                                    \
+  } while (0)
+
+// Returns NULL if the_call doesn't return napi_ok.
+#define NAPI_CALL(env, the_call)                                         \
+  NAPI_CALL_BASE(env, the_call, NULL)
+
+// Returns empty if the_call doesn't return napi_ok.
+#define NAPI_CALL_RETURN_VOID(env, the_call)                             \
+  NAPI_CALL_BASE(env, the_call, NAPI_RETVAL_NOTHING)
+
+// Returns empty if the_call doesn't return napi_ok.
+#define NAPI_CALL_RETURN_STATUS(env, the_call)                           \
+  do {                                                                   \
+    napi_status status = (the_call);                                     \
+    if (status != napi_ok) {                                             \
+      GET_AND_THROW_LAST_ERROR((env));                                   \
+      return status;                                                     \
+    }                                                                    \
+  } while (0)
+
+#define DECLARE_NAPI_PROPERTY(name, func)                                \
+  { (name), NULL, (func), NULL, NULL, NULL, napi_default, NULL }
+
+#define DECLARE_NAPI_GETTER(name, func)                                  \
+  { (name), NULL, NULL, (func), NULL, NULL, napi_default, NULL }

src/foreground-love.cc

@@ -4,26 +4,28 @@
 #include <windows.h>
 #endif
 
+#include "common.h"
+
 namespace foreground_love {
 
 napi_value AllowSetForegroundWindow(napi_env env, napi_callback_info info) {
 #if _WIN32
   napi_value argv[1];
   size_t argc = 1;
 
-  napi_get_cb_info(env, info, &argc, argv, NULL, NULL);
+  NAPI_CALL(env, napi_get_cb_info(env, info, &argc, argv, NULL, NULL));
 
   int pid = 0;
 
   if (argc != 0) {
     napi_valuetype valuetype0;
-    napi_typeof(env, argv[0], &valuetype0);
+    NAPI_CALL(env, napi_typeof(env, argv[0], &valuetype0));
 
     if (valuetype0 != napi_undefined) {
       napi_status status = napi_get_value_int32(env, argv[0], &pid);
 
       if (status != napi_ok) {
-        napi_throw_type_error(env, NULL, "Invalid number was passed as argument.");
+        NAPI_CALL(env, napi_throw_type_error(env, NULL, "Invalid number was passed as argument."));
         return NULL;
       }
     }
@@ -38,19 +40,19 @@ napi_value AllowSetForegroundWindow(napi_env env, napi_callback_info info) {
   }
 
   napi_value napi_result;
-  napi_get_boolean(env, result, &napi_result);
+  NAPI_CALL(env, napi_get_boolean(env, result, &napi_result));
 #else
   napi_value napi_result;
-  napi_get_undefined(env, &napi_result);
+  NAPI_CALL(env, napi_get_undefined(env, &napi_result));
 #endif
 
   return napi_result;
 }
 
 napi_value Init(napi_env env, napi_value exports) {
   napi_value allowSetForegroundWindow;
-  napi_create_function(env, "allowSetForegroundWindow", NAPI_AUTO_LENGTH, AllowSetForegroundWindow, NULL, &allowSetForegroundWindow);
-  napi_set_named_property(env, exports, "allowSetForegroundWindow", allowSetForegroundWindow);
+  NAPI_CALL(env, napi_create_function(env, "allowSetForegroundWindow", NAPI_AUTO_LENGTH, AllowSetForegroundWindow, NULL, &allowSetForegroundWindow));
+  NAPI_CALL(env, napi_set_named_property(env, exports, "allowSetForegroundWindow", allowSetForegroundWindow));
 
   return exports;
 }