Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Config is not object #7

Open
enumag opened this issue Dec 19, 2013 · 6 comments
Open

[BUG] Config is not object #7

enumag opened this issue Dec 19, 2013 · 6 comments
Milestone

Comments

@enumag
Copy link

enumag commented Dec 19, 2013

https://github.com/nightsh/kcfinder/blob/6f90cc65e893d421bc94675c364467e78ee4d5df/core/browser.php#L137 doesn't work at all, should be if ($this->config['multipleUsers'] == true) {

@nightsh
Copy link
Member

nightsh commented Dec 19, 2013

Sorry, the tip of the branch is a bit unstable now, until I finish the users implementation. Anyway, thank you for noticing, I'll fix that before doing anything else.
And sorry for the whole config mess in the root directory. I experimented a bit and accidentally pushed some garbage/dead code into git. Will fix that also....

@enumag
Copy link
Author

enumag commented Dec 19, 2013

Can you tag some stable release?

@enumag
Copy link
Author

enumag commented Dec 19, 2013

Yeah I noticed the mess - config.ini doesn't work at all (or so it seems), there is a security hole because KCF is enabled by defauled etc. etc.

@enumag
Copy link
Author

enumag commented Dec 19, 2013

Anyway do you recommend using http://kcfinder.sunhater.com/ for the time being or do you have some older commit which you consider stable and which doesn't suffer from config mess?

@nightsh
Copy link
Member

nightsh commented Dec 19, 2013

https://github.com/nightsh/kcfinder/tree/stable
I created a stable branch. But the last release from sunhater.com will work fine, until I'll manage to pull myself together and deal with what I started here...

Once again, sorry for causing any troubles. It's a work in progress, and it should've been a warning somewhere (I'll do this now, maybe, while indicating the stable branch).

@enumag
Copy link
Author

enumag commented Dec 19, 2013

thx

@nightsh nightsh added this to the Reboot milestone Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants