Add ability to update spec files for nodejs and gems

Author: ehelms

obal/data/modules/changelog.py

@@ -35,12 +35,12 @@ def main():
     module = AnsibleModule(
         argument_spec=dict(
             spec=dict(required=True),
-            changelog=dict(default='- rebuilt')
+            entry=dict(required=False)
         )
     )
 
     spec = module.params['spec']
-    changelog = module.params['changelog']
+    entry = module.params['entry']
 
     user = subprocess.check_output(['rpmdev-packager'], universal_newlines=True).strip()
     evr = get_specfile_evr(spec)
@@ -50,22 +50,27 @@ def main():
 
     changed = False
 
-    if not changelog.startswith('-'):
-        changelog = '- ' + changelog
+    if entry is not None and not entry.startswith('-'):
+        entry = '- ' + entry
 
     for i, line in enumerate(lines):
         if line.startswith("%changelog"):
-            with en_locale():
-                date = time.strftime("%a %b %d %Y", time.gmtime())
-            entry = "* %s %s - %s\n%s\n\n" % (date, user, evr, changelog)
-            lines[i] += entry
-            changed = True
+            if entry:
+                with en_locale():
+                    date = time.strftime("%a %b %d %Y", time.gmtime())
+                entry = "* %s %s - %s\n%s\n\n" % (date, user, evr, entry)
+                lines[i] += entry
+                changed = True
+            changelog = lines[i+1:]
             break
 
-    with open(spec, "w") as spec_file:
-        spec_file.writelines(lines)
+    if changed:
+        with open(spec, "w") as spec_file:
+            spec_file.writelines(lines)
 
-    module.exit_json(changed=changed)
+    changelog = ''.join(changelog).rstrip()
+
+    module.exit_json(changed=changed, changelog=changelog)
 
 
 if __name__ == '__main__':

obal/data/playbooks/changelog/changelog.yaml

@@ -9,4 +9,4 @@
     - name: 'ensure changelog'
       changelog:
         spec: "{{ spec_file_path }}"
-        changelog: "{{ changelog | default('- rebuilt') }}"
+        entry: "{{ changelog | default('- rebuilt') }}"

obal/data/playbooks/update-spec/metadata.obal.yaml

@@ -0,0 +1,11 @@
+help: |
+  Update a package's specfile based on a template
+
+    obal update-spec mypackage --type gem --template gem2rpm/scl.spec.erb
+variables:
+  template:
+    help: The template to use for updates
+  type:
+    help: The type of package being updated (e.g. gem)
+  strategy:
+    help: The strategy to use for an NPM package

obal/data/playbooks/update-spec/update-spec.yaml

@@ -0,0 +1,10 @@
+---
+- hosts:
+    - packages
+  serial: 1
+  gather_facts: no
+  roles:
+    - role: setup_sources
+      when: type == 'gem'
+    - spec_file
+    - update_spec_file

obal/data/playbooks/update/metadata.obal.yaml

@@ -27,3 +27,5 @@ variables:
   commit:
     help: When true, creates a git branch and commits the update changes to it.
     action: store_true
+  template:
+    help: The template to use for spec file updates

obal/data/roles/fetch_sources/tasks/main.yml

@@ -89,10 +89,10 @@
         - changelog is not defined
         - version is defined
 
-    - name: 'update spec file'
-      include_role:
-        name: update_spec_file
-
     - name: 'update source files'
       include_role:
         name: setup_sources
+
+    - name: 'update spec file'
+      include_role:
+        name: update_spec_file

obal/data/roles/update_spec_file/tasks/main.yml

@@ -58,8 +58,89 @@
     - release is defined
     - release != 'keep'
 
+- name: Set type
+  set_fact:
+    type: 'npm'
+  when: type is not defined and 'nodejs' in inventory_hostname
+
+- name: Set type
+  set_fact:
+    type: 'gem'
+  when: type is not defined and 'rubygem' in inventory_hostname
+
 - name: 'add changelog entry'
   changelog:
     spec: "{{ spec_file_path }}"
-    changelog: "{{ changelog }}"
+    entry: "{{ changelog }}"
   when: changelog is defined
+
+- name: Read changelog
+  changelog:
+    spec: "{{ spec_file_path }}"
+  register: changelog
+
+- when: type == 'gem'
+  block:
+    - name: Run spec update template
+      shell: "gem2rpm -o {{ spec_file_path }} -t {{ template }} {{ inventory_dir }}/{{ package_base_dir }}/{{ inventory_hostname }}/*.gem"
+      args:
+        chdir: "{{ inventory_dir }}"
+
+- when: type == 'npm'
+  block:
+    - name: Find version
+      shell: "rpmspec --srpm -q --queryformat=%{version} {{ spec_file_path }}"
+      args:
+        chdir: "{{ inventory_dir }}"
+      register: version_output
+      when: version is not defined
+
+    - name: Find release
+      shell: "rpmspec --srpm -q --queryformat=%{release} {{ spec_file_path }}"
+      args:
+        chdir: "{{ inventory_dir }}"
+      register: release_output
+      when: release is not defined
+
+    - name: Set version
+      set_fact:
+        version: "{{ version_output.stdout }}"
+      when: version is not defined
+
+    - name: Set release
+      set_fact:
+        release: "{{ release_output.stdout }}"
+      when: release is not defined
+
+    - name: Find all sources to remove
+      find:
+        paths: "{{ inventory_dir }}/{{ package_base_dir }}/{{ inventory_hostname }}"
+        patterns: "*.tgz"
+        file_type: any
+      register: files_to_remove
+
+    - name: Remove old sources
+      file:
+        state: absent
+        path: "{{ item.path }}"
+      with_items: "{{ files_to_remove.files }}"
+
+    - name: Run spec update template
+      command: "npm2rpm -s {{ strategy | default('single') }} -n {{ name | default(inventory_hostname.replace('nodejs-', '')) }} -v {{ version }} -o . -c"
+      args:
+        chdir: "{{ inventory_dir }}/{{ package_base_dir }}/{{ inventory_hostname }}"
+
+    - name: Add release back
+      replace:
+        path: "{{ spec_file_path }}"
+        regexp: "Release: 1"
+        replace: "Release: {{ release }}"
+
+    - import_role:
+        name: setup_sources
+
+- name: Add back changelog
+  lineinfile:
+    path: "{{ spec_file_path }}"
+    insertafter: "%changelog"
+    line: "{{ changelog.changelog }}"