Fix W3C WebDriver API detection for IE.

edhager · edhager · commit e99e90e9b404 · 2019-05-13T15:17:43.000-07:00
diff --git a/docs/api.json b/docs/api.json
@@ -37521,7 +37521,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 263,
+									"line": 261,
 									"character": 63
 								}
 							],
@@ -37572,7 +37572,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 261,
+									"line": 259,
 									"character": 29
 								}
 							],
@@ -37599,7 +37599,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 260,
+									"line": 258,
 									"character": 22
 								}
 							],
@@ -37692,7 +37692,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 306,
+									"line": 304,
 									"character": 16
 								}
 							],
@@ -37776,7 +37776,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 290,
+									"line": 288,
 									"character": 9
 								}
 							],
@@ -37849,7 +37849,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 310,
+									"line": 308,
 									"character": 21
 								}
 							],
@@ -37898,7 +37898,7 @@
 					"sources": [
 						{
 							"fileName": "lib/webDriverConfig.ts",
-							"line": 257,
+							"line": 255,
 							"character": 29
 						}
 					],
@@ -38459,7 +38459,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 327,
+									"line": 325,
 									"character": 37
 								}
 							],
@@ -38510,7 +38510,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 327,
+									"line": 325,
 									"character": 28
 								}
 							],
@@ -38537,7 +38537,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 326,
+									"line": 324,
 									"character": 22
 								}
 							],
@@ -38583,7 +38583,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 348,
+									"line": 346,
 									"character": 14
 								}
 							]
@@ -38709,7 +38709,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 354,
+									"line": 352,
 									"character": 9
 								}
 							],
@@ -38782,7 +38782,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 364,
+									"line": 359,
 									"character": 21
 								}
 							],
@@ -38831,7 +38831,7 @@
 					"sources": [
 						{
 							"fileName": "lib/webDriverConfig.ts",
-							"line": 323,
+							"line": 321,
 							"character": 35
 						}
 					],
@@ -39170,7 +39170,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 241,
+									"line": 239,
 									"character": 21
 								}
 							],
@@ -39715,7 +39715,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 254,
+									"line": 252,
 									"character": 15
 								}
 							],
@@ -39788,7 +39788,7 @@
 					"sources": [
 						{
 							"fileName": "lib/webDriverConfig.ts",
-							"line": 253,
+							"line": 251,
 							"character": 40
 						}
 					],
@@ -40579,9 +40579,9 @@
 					],
 					"type": {
 						"type": "stringLiteral",
-						"value": "3.141.0"
+						"value": "3.14.0"
 					},
-					"defaultValue": "\"3.141.0\""
+					"defaultValue": "\"3.14.0\""
 				},
 				{
 					"id": 1328,
@@ -40618,7 +40618,7 @@
 					"sources": [
 						{
 							"fileName": "lib/webDriverConfig.ts",
-							"line": 377,
+							"line": 371,
 							"character": 34
 						}
 					],
@@ -40673,7 +40673,7 @@
 							"sources": [
 								{
 									"fileName": "lib/webDriverConfig.ts",
-									"line": 377,
+									"line": 371,
 									"character": 35
 								}
 							]
diff --git a/src/lib/webDriverConfig.ts b/src/lib/webDriverConfig.ts
@@ -223,9 +223,7 @@ export class SafariDriverConfig
       Object.assign(
         {
           arch: process.arch,
-          baseUrl: 'https://github.com/mozilla/geckodriver/releases/download',
-          platform: process.platform,
-          version: FirefoxVersion
+          platform: process.platform
         },
         config
       )
@@ -342,7 +340,7 @@ export class InternetExplorerConfig
     this.name = INTERNET_EXPLORER;
     this.executable = 'IEDriverServer.exe';
     // Download only when the platform is Windows.
-    config.noDownload = process.platform !== 'win32';
+    this.config.noDownload = process.platform !== 'win32';
   }
 
   get artifact() {

Original file line number	Diff line number	Diff line change
`@@ -37521,7 +37521,7 @@`
`37521`	`37521`	`"sources": [`
`37522`	`37522`	`{`
`37523`	`37523`	`"fileName": "lib/webDriverConfig.ts",`
`37524`		`- "line": 263,`
	`37524`	`+ "line": 261,`
`37525`	`37525`	`"character": 63`
`37526`	`37526`	`}`
`37527`	`37527`	`],`
`@@ -37572,7 +37572,7 @@`
`37572`	`37572`	`"sources": [`
`37573`	`37573`	`{`
`37574`	`37574`	`"fileName": "lib/webDriverConfig.ts",`
`37575`		`- "line": 261,`
	`37575`	`+ "line": 259,`
`37576`	`37576`	`"character": 29`
`37577`	`37577`	`}`
`37578`	`37578`	`],`
`@@ -37599,7 +37599,7 @@`
`37599`	`37599`	`"sources": [`
`37600`	`37600`	`{`
`37601`	`37601`	`"fileName": "lib/webDriverConfig.ts",`
`37602`		`- "line": 260,`
	`37602`	`+ "line": 258,`
`37603`	`37603`	`"character": 22`
`37604`	`37604`	`}`
`37605`	`37605`	`],`
`@@ -37692,7 +37692,7 @@`
`37692`	`37692`	`"sources": [`
`37693`	`37693`	`{`
`37694`	`37694`	`"fileName": "lib/webDriverConfig.ts",`
`37695`		`- "line": 306,`
	`37695`	`+ "line": 304,`
`37696`	`37696`	`"character": 16`
`37697`	`37697`	`}`
`37698`	`37698`	`],`
`@@ -37776,7 +37776,7 @@`
`37776`	`37776`	`"sources": [`
`37777`	`37777`	`{`
`37778`	`37778`	`"fileName": "lib/webDriverConfig.ts",`
`37779`		`- "line": 290,`
	`37779`	`+ "line": 288,`
`37780`	`37780`	`"character": 9`
`37781`	`37781`	`}`
`37782`	`37782`	`],`
`@@ -37849,7 +37849,7 @@`
`37849`	`37849`	`"sources": [`
`37850`	`37850`	`{`
`37851`	`37851`	`"fileName": "lib/webDriverConfig.ts",`
`37852`		`- "line": 310,`
	`37852`	`+ "line": 308,`
`37853`	`37853`	`"character": 21`
`37854`	`37854`	`}`
`37855`	`37855`	`],`
`@@ -37898,7 +37898,7 @@`
`37898`	`37898`	`"sources": [`
`37899`	`37899`	`{`
`37900`	`37900`	`"fileName": "lib/webDriverConfig.ts",`
`37901`		`- "line": 257,`
	`37901`	`+ "line": 255,`
`37902`	`37902`	`"character": 29`
`37903`	`37903`	`}`
`37904`	`37904`	`],`
`@@ -38459,7 +38459,7 @@`
`38459`	`38459`	`"sources": [`
`38460`	`38460`	`{`
`38461`	`38461`	`"fileName": "lib/webDriverConfig.ts",`
`38462`		`- "line": 327,`
	`38462`	`+ "line": 325,`
`38463`	`38463`	`"character": 37`
`38464`	`38464`	`}`
`38465`	`38465`	`],`
`@@ -38510,7 +38510,7 @@`
`38510`	`38510`	`"sources": [`
`38511`	`38511`	`{`
`38512`	`38512`	`"fileName": "lib/webDriverConfig.ts",`
`38513`		`- "line": 327,`
	`38513`	`+ "line": 325,`
`38514`	`38514`	`"character": 28`
`38515`	`38515`	`}`
`38516`	`38516`	`],`
`@@ -38537,7 +38537,7 @@`
`38537`	`38537`	`"sources": [`
`38538`	`38538`	`{`
`38539`	`38539`	`"fileName": "lib/webDriverConfig.ts",`
`38540`		`- "line": 326,`
	`38540`	`+ "line": 324,`
`38541`	`38541`	`"character": 22`
`38542`	`38542`	`}`
`38543`	`38543`	`],`
`@@ -38583,7 +38583,7 @@`
`38583`	`38583`	`"sources": [`
`38584`	`38584`	`{`
`38585`	`38585`	`"fileName": "lib/webDriverConfig.ts",`
`38586`		`- "line": 348,`
	`38586`	`+ "line": 346,`
`38587`	`38587`	`"character": 14`
`38588`	`38588`	`}`
`38589`	`38589`	`]`
`@@ -38709,7 +38709,7 @@`
`38709`	`38709`	`"sources": [`
`38710`	`38710`	`{`
`38711`	`38711`	`"fileName": "lib/webDriverConfig.ts",`
`38712`		`- "line": 354,`
	`38712`	`+ "line": 352,`
`38713`	`38713`	`"character": 9`
`38714`	`38714`	`}`
`38715`	`38715`	`],`
`@@ -38782,7 +38782,7 @@`
`38782`	`38782`	`"sources": [`
`38783`	`38783`	`{`
`38784`	`38784`	`"fileName": "lib/webDriverConfig.ts",`
`38785`		`- "line": 364,`
	`38785`	`+ "line": 359,`
`38786`	`38786`	`"character": 21`
`38787`	`38787`	`}`
`38788`	`38788`	`],`
`@@ -38831,7 +38831,7 @@`
`38831`	`38831`	`"sources": [`
`38832`	`38832`	`{`
`38833`	`38833`	`"fileName": "lib/webDriverConfig.ts",`
`38834`		`- "line": 323,`
	`38834`	`+ "line": 321,`
`38835`	`38835`	`"character": 35`
`38836`	`38836`	`}`
`38837`	`38837`	`],`
`@@ -39170,7 +39170,7 @@`
`39170`	`39170`	`"sources": [`
`39171`	`39171`	`{`
`39172`	`39172`	`"fileName": "lib/webDriverConfig.ts",`
`39173`		`- "line": 241,`
	`39173`	`+ "line": 239,`
`39174`	`39174`	`"character": 21`
`39175`	`39175`	`}`
`39176`	`39176`	`],`
`@@ -39715,7 +39715,7 @@`
`39715`	`39715`	`"sources": [`
`39716`	`39716`	`{`
`39717`	`39717`	`"fileName": "lib/webDriverConfig.ts",`
`39718`		`- "line": 254,`
	`39718`	`+ "line": 252,`
`39719`	`39719`	`"character": 15`
`39720`	`39720`	`}`
`39721`	`39721`	`],`
`@@ -39788,7 +39788,7 @@`
`39788`	`39788`	`"sources": [`
`39789`	`39789`	`{`
`39790`	`39790`	`"fileName": "lib/webDriverConfig.ts",`
`39791`		`- "line": 253,`
	`39791`	`+ "line": 251,`
`39792`	`39792`	`"character": 40`
`39793`	`39793`	`}`
`39794`	`39794`	`],`
`@@ -40579,9 +40579,9 @@`
`40579`	`40579`	`],`
`40580`	`40580`	`"type": {`
`40581`	`40581`	`"type": "stringLiteral",`
`40582`		`- "value": "3.141.0"`
	`40582`	`+ "value": "3.14.0"`
`40583`	`40583`	`},`
`40584`		`- "defaultValue": "\"3.141.0\""`
	`40584`	`+ "defaultValue": "\"3.14.0\""`
`40585`	`40585`	`},`
`40586`	`40586`	`{`
`40587`	`40587`	`"id": 1328,`
`@@ -40618,7 +40618,7 @@`
`40618`	`40618`	`"sources": [`
`40619`	`40619`	`{`
`40620`	`40620`	`"fileName": "lib/webDriverConfig.ts",`
`40621`		`- "line": 377,`
	`40621`	`+ "line": 371,`
`40622`	`40622`	`"character": 34`
`40623`	`40623`	`}`
`40624`	`40624`	`],`
`@@ -40673,7 +40673,7 @@`
`40673`	`40673`	`"sources": [`
`40674`	`40674`	`{`
`40675`	`40675`	`"fileName": "lib/webDriverConfig.ts",`
`40676`		`- "line": 377,`
	`40676`	`+ "line": 371,`
`40677`	`40677`	`"character": 35`
`40678`	`40678`	`}`
`40679`	`40679`	`]`
Original file line number	Diff line number	Diff line change
`@@ -223,9 +223,7 @@ export class SafariDriverConfig`
`223`	`223`	`Object.assign(`
`224`	`224`	`{`
`225`	`225`	`arch: process.arch,`
`226`		`- baseUrl: 'https://github.com/mozilla/geckodriver/releases/download',`
`227`		`- platform: process.platform,`
`228`		`- version: FirefoxVersion`
	`226`	`+ platform: process.platform`
`229`	`227`	`},`
`230`	`228`	`config`
`231`	`229`	`)`
`@@ -342,7 +340,7 @@ export class InternetExplorerConfig`
`342`	`340`	`this.name = INTERNET_EXPLORER;`
`343`	`341`	`this.executable = 'IEDriverServer.exe';`
`344`	`342`	`// Download only when the platform is Windows.`
`345`		`- config.noDownload = process.platform !== 'win32';`
	`343`	`+ this.config.noDownload = process.platform !== 'win32';`
`346`	`344`	`}`
`347`	`345`
`348`	`346`	`get artifact() {`