Add phpstan/larastan

abenerd · abenerd · commit b56d5e8bcc94 · 2021-07-26T12:54:21.000+02:00
diff --git a/.github/workflows/phpstan.yml b/.github/workflows/phpstan.yml
@@ -0,0 +1,26 @@
+name: PHPStan
+
+on:
+  push:
+    paths:
+      - '**.php'
+      - 'phpstan.neon.dist'
+
+jobs:
+  phpstan:
+    name: phpstan
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.0'
+          coverage: none
+
+      - name: Install composer dependencies
+        uses: ramsey/composer-install@v1
+
+      - name: Run PHPStan
+        run: ./vendor/bin/phpstan --error-format=github
diff --git a/.github/workflows/psalm.yml b/.github/workflows/psalm.yml
diff --git a/.gitignore b/.gitignore
@@ -7,7 +7,7 @@ composer.lock
 coverage
 docs
 phpunit.xml
-psalm.xml
+phpstan.neon
 testbench.yaml
 vendor
 node_modules
diff --git a/composer.json b/composer.json
@@ -23,10 +23,13 @@
     "require-dev": {
         "brianium/paratest": "^6.2",
         "nunomaduro/collision": "^5.3",
+        "nunomaduro/larastan": "^0.7.10",
         "orchestra/testbench": "^6.15",
+        "phpstan/extension-installer": "^1.1",
+        "phpstan/phpstan-deprecation-rules": "^0.12.6",
+        "phpstan/phpstan-phpunit": "^0.12.21",
         "phpunit/phpunit": "^9.3",
-        "spatie/laravel-ray": "^1.23",
-        "vimeo/psalm": "^4.8"
+        "spatie/laravel-ray": "^1.23"
     },
     "autoload": {
         "psr-4": {
@@ -40,7 +43,7 @@
         }
     },
     "scripts": {
-        "psalm": "vendor/bin/psalm",
+        "phpstan": "vendor/bin/phpstan analyse",
         "test": "./vendor/bin/testbench package:test --parallel --no-coverage",
         "test-coverage": "vendor/bin/phpunit --coverage-html coverage"
     },
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -0,0 +1,15 @@
+includes:
+    - phpstan-baseline.neon
+
+parameters:
+    level: 4
+    paths:
+        - src
+        - config
+        - database
+        - tests
+    tmpDir: build/phpstan
+    checkOctaneCompatibility: true
+    checkModelProperties: true
+    checkMissingIterableValueType: false
+
diff --git a/psalm.xml.dist b/psalm.xml.dist
diff --git a/src/Commands/SkeletonCommand.php b/src/Commands/SkeletonCommand.php
@@ -10,8 +10,10 @@ class SkeletonCommand extends Command
 
     public $description = 'My command';
 
-    public function handle()
+    public function handle(): int
     {
         $this->comment('All done');
+
+        return self::SUCCESS;
     }
 }
diff --git a/tests/ExampleTest.php b/tests/ExampleTest.php
@@ -5,7 +5,7 @@
 class ExampleTest extends TestCase
 {
     /** @test */
-    public function true_is_true()
+    public function true_is_true(): void
     {
         $this->assertTrue(true);
     }

Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,10 @@ class SkeletonCommand extends Command`
`10`	`10`
`11`	`11`	`public $description = 'My command';`
`12`	`12`
`13`		`- public function handle()`
	`13`	`+ public function handle(): int`
`14`	`14`	`{`
`15`	`15`	`$this->comment('All done');`
	`16`	`+`
	`17`	`+ return self::SUCCESS;`
`16`	`18`	`}`
`17`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`class ExampleTest extends TestCase`
`6`	`6`	`{`
`7`	`7`	`/** @test */`
`8`		`- public function true_is_true()`
	`8`	`+ public function true_is_true(): void`
`9`	`9`	`{`
`10`	`10`	`$this->assertTrue(true);`
`11`	`11`	`}`