Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback tests missing targets rollback #133

Closed
jku opened this issue Aug 13, 2024 · 0 comments · Fixed by #154
Closed

rollback tests missing targets rollback #133

jku opened this issue Aug 13, 2024 · 0 comments · Fixed by #154
Assignees

Comments

@jku
Copy link
Member

jku commented Aug 13, 2024

  • client must not accept the version of any targets roles in snapshot to decrease: we don't have tests specifically for this
  • test_snapshot_rollback_with_local_snapshot_hash_mismatch() tries but currently fails to test this with hashes/length included in snapshot but we should have the basic rollback test first (as mentioned in Add tests for hashes/length in metafiles #131 maybe we can run all the rollback tests with hashes/length in addition to without them)
  • there is another rollback-related test we should have: client should not allow targets roles to be removed from snapshot
    (except when snapshot keys are rotated but I think that's covered byt the fast_forward tests)
@jku jku self-assigned this Aug 16, 2024
This was linked to pull requests Aug 16, 2024
@jku jku closed this as completed in #154 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant