Skip to content

Commit 8ddce91

Browse files
committed
Improve test assertion
1 parent 9670b04 commit 8ddce91

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

test/ModularPipelines.UnitTests/NotInParallelTests.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
namespace ModularPipelines.UnitTests;
77

8+
[Retry(3)]
89
public class NotInParallelTests
910
{
1011
[ModularPipelines.Attributes.NotInParallel]
@@ -58,7 +59,7 @@ public class NotParallelModuleWithNonParallelDependency : Module<string>
5859
}
5960
}
6061

61-
[Test, Retry(3)]
62+
[Test]
6263
public async Task NotInParallel()
6364
{
6465
var results = await TestPipelineHostBuilder.Create()
@@ -69,11 +70,10 @@ public async Task NotInParallel()
6970
var firstModule = results.Modules.MinBy(x => x.EndTime)!;
7071
var nextModule = results.Modules.MaxBy(x => x.EndTime)!;
7172
await Assert.That(nextModule.StartTime)
72-
.Is.EqualToWithTolerance(firstModule.StartTime + TimeSpan.FromSeconds(5),
73-
TimeSpan.FromSeconds(1));
73+
.Is.GreaterThanOrEqualTo(firstModule.StartTime + TimeSpan.FromSeconds(5));
7474
}
7575

76-
[Test, Retry(3)]
76+
[Test]
7777
public async Task NotInParallel_With_ParallelDependency()
7878
{
7979
var results = await TestPipelineHostBuilder.Create()
@@ -84,10 +84,10 @@ public async Task NotInParallel_With_ParallelDependency()
8484
var firstModule = results.Modules.MinBy(x => x.EndTime)!;
8585
var nextModule = results.Modules.MaxBy(x => x.EndTime)!;
8686
await Assert.That(nextModule.StartTime)
87-
.Is.EqualToWithTolerance(firstModule.StartTime + TimeSpan.FromSeconds(5), TimeSpan.FromSeconds(1));
87+
.Is.GreaterThanOrEqualTo(firstModule.StartTime + TimeSpan.FromSeconds(5));
8888
}
8989

90-
[Test, Retry(3)]
90+
[Test]
9191
public async Task NotInParallel_With_NonParallelDependency()
9292
{
9393
var results = await TestPipelineHostBuilder.Create()
@@ -102,6 +102,6 @@ public async Task NotInParallel_With_NonParallelDependency()
102102
var expectedStartTime = firstModule.StartTime + TimeSpan.FromSeconds(10);
103103

104104
await Assert.That(nextModule.StartTime)
105-
.Is.EqualToWithTolerance(expectedStartTime, TimeSpan.FromSeconds(1));
105+
.Is.GreaterThanOrEqualTo(expectedStartTime);
106106
}
107107
}

test/ModularPipelines.UnitTests/ParallelLimiterTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
namespace ModularPipelines.UnitTests;
77

8+
[Retry(3)]
89
public class ParallelLimiterTests
910
{
1011
[ModularPipelines.Attributes.ParallelLimiter<MyParallelLimit>]
@@ -68,7 +69,7 @@ public class Module6 : Module<string>
6869
}
6970
}
7071

71-
[Test, Repeat(3)]
72+
[Test]
7273
public async Task LimitParallel()
7374
{
7475
var results = await TestPipelineHostBuilder.Create()

0 commit comments

Comments
 (0)