Run most nested dependencies first (#984)

Author: thomhurst

src/ModularPipelines.GitHub/GitHubRepositoryInfo.cs

@@ -39,55 +39,62 @@ public async Task InitializeAsync()
     {
       return;
     }
-    
-    await using var scope = _serviceProvider.CreateAsyncScope();
-    var git = scope.ServiceProvider.GetRequiredService<IGit>();
 
-    var options = new GitRemoteOptions
+    try
     {
-      Arguments = ["get-url", "origin"],
-      ThrowOnNonZeroExitCode = false,
-      CommandLogging = scope.ServiceProvider
-                         .GetRequiredService<IOptions<LoggerFilterOptions>>()
-                         .Value
-                         .MinLevel == LogLevel.Debug
-        ? CommandLogging.Default
-        : CommandLogging.None,
-    };
+      await using var scope = _serviceProvider.CreateAsyncScope();
+      var git = scope.ServiceProvider.GetRequiredService<IGit>();
+
+      var options = new GitRemoteOptions
+      {
+        Arguments = ["get-url", "origin"],
+        ThrowOnNonZeroExitCode = false,
+        CommandLogging = scope.ServiceProvider
+          .GetRequiredService<IOptions<LoggerFilterOptions>>()
+          .Value
+          .MinLevel == LogLevel.Debug
+          ? CommandLogging.Default
+          : CommandLogging.None,
+      };
 
-    var remote = await git.Commands.Remote(options);
-    var remoteUrl = remote.StandardOutput;
+      var remote = await git.Commands.Remote(options);
+      var remoteUrl = remote.StandardOutput;
 
-    if (string.IsNullOrEmpty(remoteUrl))
-    {
-      _logger.LogWarning("Error when detecting GitHub git repository: {Error}", remote.StandardError);
+      if (string.IsNullOrEmpty(remoteUrl))
+      {
+        _logger.LogWarning("Error when detecting GitHub git repository: {Error}", remote.StandardError);
 
-      // Will not initialize as git repo is not setup
-      return;
-    }
+        // Will not initialize as git repo is not setup
+        return;
+      }
 
-    // Parse owner and repository name from the remote URL
-    var endpoint = "github";
-    var sshPattern = $@"git@{endpoint}\.com:(?<owner>.+)/(?<name>.+)\.git";
-    var httpsPattern = $@"https://(.*@)?{endpoint}\.com/(?<owner>.+)/(?<name>.+)(\.git)?";
+      // Parse owner and repository name from the remote URL
+      var endpoint = "github";
+      var sshPattern = $@"git@{endpoint}\.com:(?<owner>.+)/(?<name>.+)\.git";
+      var httpsPattern = $@"https://(.*@)?{endpoint}\.com/(?<owner>.+)/(?<name>.+)(\.git)?";
 
-    var match = Regex.Match(remoteUrl, sshPattern);
-    if (!match.Success)
-    {
-      match = Regex.Match(remoteUrl, httpsPattern);
-    }
+      var match = Regex.Match(remoteUrl, sshPattern);
+      if (!match.Success)
+      {
+        match = Regex.Match(remoteUrl, httpsPattern);
+      }
 
-    if (!match.Success)
-    {
-      // Will not initialize as git repo is not setup
-      return;
-    }
+      if (!match.Success)
+      {
+        // Will not initialize as git repo is not setup
+        return;
+      }
 
-    Url = remoteUrl;
-    Endpoint = endpoint;
-    Owner = match.Groups["owner"].Value;
-    RepositoryName = match.Groups["name"].Value;
+      Url = remoteUrl;
+      Endpoint = endpoint;
+      Owner = match.Groups["owner"].Value;
+      RepositoryName = match.Groups["name"].Value;
 
-    IsInitialized = true;
+      IsInitialized = true;
+    }
+    catch (Exception e)
+    {
+      Console.WriteLine(e);
+    }
   }
 }

src/ModularPipelines/Engine/ModuleExecutor.cs

@@ -163,7 +163,7 @@ private Task<ModuleBase> StartModule(ModuleBase module, bool isStartedAsDependen
 
                 var dependencies = module.GetModuleDependencies();
 
-                foreach (var dependency in dependencies)
+                foreach (var dependency in dependencies.Reverse())
                 {
                     await StartDependency(module, dependency.DependencyType, dependency.IgnoreIfNotRegistered);
                 }