Skip to content

IHttpLogger spams messages #1318

@Nice3point

Description

@Nice3point

The ModularPipelines.GitHub.GitHub class has IHttpLogger, but it is overly aggressive. For example, for a call to

        return await targetFiles
            .SelectAsync(async file =>
                {
                    var asset = new ReleaseAssetUpload
                    {
                        ContentType = "application/x-binary",
                        FileName = file.Name,
                        RawData = file.GetStream()
                    };

                    return await context.GitHub().Client.Repository.Release.UploadAsset(release, asset, cancellationToken);
                },
                cancellationToken)
            .ProcessOneAtATime();

I get >15,000 lines in the output. The current implementation even logs the stream of the uploaded file.

Image Image

Ideally nice to have something like CommandLogging in Commands, to control it

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions