Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements manager with overlays #1180

Open
1 task
KPostOffice opened this issue Nov 29, 2022 · 3 comments
Open
1 task

requirements manager with overlays #1180

KPostOffice opened this issue Nov 29, 2022 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@KPostOffice
Copy link
Member

Problem statement

Currently requirements manager only works if the pipenv files are in the root directory. Logic should be added — similar to that in adviser — to create requirements.txt files in overlay directories.

High-level Goals

requirements manager in project with overlays directory will create requirements.txt in overlay directories

Proposal description

Add a loop for a list of environments to the pipfile_requirements manager

Acceptance Criteria

  • example
@KPostOffice KPostOffice added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 29, 2022
@KPostOffice KPostOffice moved this to 🆕 New in Planning Board Nov 29, 2022
@KPostOffice KPostOffice added needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. labels Nov 29, 2022
@Gkrumbach07
Copy link
Member

@KPostOffice Does this issue solve the issue?

@KPostOffice
Copy link
Member Author

It doesn't quite, though the changes should be minimal. This issue requires adding code to get the location of the requirements file somewhere around here. The basic idea is if overlays_dir is set then all the work should be done in <overlays_dir>/<environment_name> rather than the root directory

@Gkrumbach07
Copy link
Member

/triage accepted
/priority backlog

acceptance criteria

  • use location of overlays_directory if set

@sesheta sesheta added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Feb 1, 2023
@Gkrumbach07 Gkrumbach07 removed the needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. label Feb 1, 2023
@Gkrumbach07 Gkrumbach07 moved this from 🆕 New to 📋 Backlog in Planning Board Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants