tools: Bad conversion between github quote blocks and readme quote blocks (#11)

Author: codeallthethingz

tools/github_readme_sync/readme.py

@@ -230,11 +230,11 @@ def replace_path(match):
 
     def convert_note_tags(self, body: str) -> str:
         conversions = {
-            r">\s*\[!NOTE\]\s*": "> 📘 ",
-            r">\s*\[!TIP\]\s*": "> 👍 ",
-            r">\s*\[!IMPORTANT\]\s*": "> 📘 ",
-            r">\s*\[!WARNING\]\s*": "> 🚧 ",
-            r">\s*\[!CAUTION\]\s*": "> ❗️ ",
+            r"\[!NOTE\]": "📘",
+            r"\[!TIP\]": "👍",
+            r"\[!IMPORTANT\]": "📘",
+            r"\[!WARNING\]": "🚧",
+            r"\[!CAUTION\]": "❗️",
         }
 
         for old, new in conversions.items():

tools/github_readme_sync/tests/readme_test.py

@@ -429,7 +429,24 @@ def test_correct_image_locations_no_repo_env(self):
             str(context.exception), "IMAGE_PATH environment variable not set"
         )
 
-    def test_convert_note_tags(self):
+    def test_convert_note_tags_with_link(self):
+        input_text = """
+        > [!NOTE]
+        > You can find our code at https://github.com/thousandbrainsproject/tbp.monty
+        >
+        > This is our open-source repository. We call it **Monty** after
+        """
+
+        expected_output = """
+        > 📘
+        > You can find our code at https://github.com/thousandbrainsproject/tbp.monty
+        >
+        > This is our open-source repository. We call it **Monty** after
+        """
+
+        self.assertEqual(
+            self.readme.convert_note_tags(input_text).strip(), expected_output.strip()
+        )
         input_text = """
         > [!NOTE]    This is a note.
         >   [!TIP]    Here's a tip.
@@ -439,10 +456,10 @@ def test_convert_note_tags(self):
         """
 
         expected_output = """
-        > 📘 This is a note.
-        > 👍 Here's a tip.
-        > 📘 This is important.
-        > 🚧 This is a warning.
+        > 📘    This is a note.
+        >   👍    Here's a tip.
+        > 📘  This is important.
+        >     🚧 This is a warning.
         > ❗️ Be cautious!
         """