E_showMenu_F18/Q3: rm internal l as cb func arg

Remove internal menu object `l` as argument to callback function.

This removes a potential for memory leaks and should otherwise have no
impact. As no app on the main BangleApps repo seems to use the option.
See espruino#2567.

closes espruino#2567

Author: thyttan

ChangeLog

@@ -38,6 +38,7 @@
             removeListener while executing events no longer stops subsequent listeners from executing (#2151)
             jsvObjectIterator is now safe even if not called on something iterable
             X.on now always allocates an array - tidies up code (fix #2559)
+            Bangle.js: E.showMenu no longer sends the internal `l` menu object as argument when running the callback function.
 
      2v24 : Bangle.js2: Add 'Bangle.touchRd()', 'Bangle.touchWr()'
             Bangle.js2: After Bangle.showTestScreen, put Bangle.js into a hard off state (not soft off)

libs/js/banglejs/E_showMenu_F18.js

@@ -142,7 +142,7 @@
           item.onchange(item.value);
           l.draw(options.selected, options.selected);
         }
-      } else if ("function" == typeof item) item(l);
+      } else if ("function" == typeof item) item();
       else if ("object" == typeof item) {
         // if a number, go into 'edit mode'
         if ("number" == typeof item.value) {
@@ -198,4 +198,4 @@
   };
   l.draw();
   return l;
-})
+})

libs/js/banglejs/E_showMenu_F18.min.js

@@ -137,7 +137,7 @@
       if (idx<0) return back&&back(); // title
       var item = menu[keys[idx]];
       Bangle.buzz(20);
-      if ("function" == typeof item) item(l);
+      if ("function" == typeof item) item();
       else if ("object" == typeof item) {
         // if a bool, just toggle it
         if ("number" == typeof item.value) {