Skip to content

PatchSet operations fail from local git user.name configuration #264

@ndhaller

Description

@ndhaller

During "edkrepo clone" and "edkrepo checkout", Dynamic Branch Creation PatchSet operations fail with generic git failure messages if local git configurations have not set a user.name and user.email.

To reproduce, clear global user.name and user.email configuration before clone or checkout command on a project and combination that implements a PatchSet recipe.

git config --global user.name ""
git config --global user.email ""
edkrepo checkout [Combination]
...
Failed to cherry pick the commit [commit SHA]
Failed to apply one of the patchset operations. Checking out back to the default branch

Directly running git revert and git cherry-pick commands confirm the failure is from user.name and user.email local git configuration and not from the patchSet recipe.

git cherry-pick --continue
Committer identity unknown

*** Please tell me who you are.

Run

  git config --global user.email "[email protected]"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

Possibly add a check for non-empty git user.name and user.email at the start of patchset operations and exit with a new edkrepo error message instead of attempting the git cherry-pick/revert commands and failing with generic git failure message.

system configuration:
edkrepo 3.2.0
git version 2.43.0.windows.1
Python 3.8.19
Microsoft Windows 11 Enterprise

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions