[Bug]: Ampere platform(s?) not buildable by default - [Platform/Ampere/JadePkg]

[leiflindholm]

Is there an existing issue for this?

• I have searched existing issues

Bug Type

• Firmware
• Tool
• Unit Test

What packages are impacted?

Platform/Ampere/JadePkg

Which targets are impacted by this bug?

No response

Current Behavior

Platforms should really be buildable by default, but when trying to test-build rectifications of the move of ArmMmuLib to UefiCpuPkg, I found two issues preventing this for at least JadePkg:

• unless passed -D UEFI_SECURE_BOOT_ENABLE=false on command line, the build fails due to the platform key not existing in the upstream tree.
• HostFwInfo.h is missing for SystemFirmwareDescriptor.aslc unless Platform/Ampere/buildfw.sh has been executed.

Expected Behavior

I understand the desire to provide a solid starting point for derivative platforms, by not providing defaults that would be problematic in end products. But I think this needs to be made friendlier for the drive-by tweaker.

Steps To Reproduce

Try to perform a simple build -a "AARCH64" -t GCC -p "Platform/Ampere/JadePkg/Jade.dsc" -b "RELEASE" and see it fail.

Build Environment

All.

Version Information

HEAD

Urgency

Medium

Are you going to fix this?

Someone else needs to fix it

Do you need maintainer feedback?

Maintainer feedback requested

Anything else?

No response

[nhivp]

Hi @bexcran, can you help look at this?

[bexcran]

Platforms should really be buildable by default

I agree, but in addition I believe platforms should be usable by default too. The build command doesn't generate something people can use to flash to the SPI-NOR chip on Ampere-based systems which is why I introduced buildfw.sh by reverse-engineering https://github.com/AmpereComputing/edk2-ampere-tools/blob/master/Makefile and adding support for building parts even if the user doesn't have access to the NDA'd binaries.

I tend to dislike the extra dependencies introduced by the Stuart build system, but would it be acceptable if build didn't work but stuart_build did?