Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): indent log correctly #14030

Merged
merged 2 commits into from
May 13, 2024
Merged

feat(android): indent log correctly #14030

merged 2 commits into from
May 13, 2024

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented May 8, 2024

Remove the trim() from the logout put to keep e.g. JSON indentation.

console.log("#TEST#");
console.log([{"foo":"bar", "test": 1}]);
console.log(JSON.stringify([{"foo":"bar", "test": 1}]));
console.log(JSON.stringify([{"foo":"bar", "test": 1}], null, 2));

output with the PR:

[INFO]  #TEST#
[INFO]  [ { foo: 'bar', test: 1 } ]
[INFO]  [{"foo":"bar","test":1}]
[INFO]  [
[INFO]   {
[INFO]     "foo": "bar",
[INFO]     "test": 1
[INFO]   }
[INFO]  ]

output before:

[INFO]  #TEST#
[INFO]  [ { foo: 'bar', test: 1 } ]
[INFO]  [{"foo":"bar","test":1}]
[INFO]  [
[INFO]  {
[INFO]  "foo": "bar",
[INFO]  "test": 1
[INFO]  }
[INFO]  ]

cb1kenobi
cb1kenobi approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good! APPROVED!

@cb1kenobi cb1kenobi merged commit a7b145d into master May 13, 2024
4 checks passed
@m1ga m1ga deleted the jsonLog branch May 29, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1ga @cb1kenobi