changes for #68

Author: topepo

NEWS.md

@@ -4,6 +4,8 @@
 
 * Various changes and improvements to error and warning messages. 
 
+* Fixed a bug that occurred when linear activation was used for neural networks (#68). 
+
 # brulee 0.3.0
 
 * Fixed bug where `coef()` didn't would error if used on a `brulee_logistic_reg()` that was trained with a recipe. (#66)

R/activation.R

@@ -15,11 +15,11 @@ brulee_activations <- function() {
 get_activation_fn <- function(arg, ...) {
 
  if (arg == "linear") {
-  res <- identity
- } else {
-  cl <- rlang::call2(paste0("nn_", arg), .ns = "torch")
-  res <- rlang::eval_bare(cl)
+  arg <- "identity"
  }
 
+ cl <- rlang::call2(paste0("nn_", arg), .ns = "torch")
+ res <- rlang::eval_bare(cl)
+
  res
 }

tests/testthat/test-mlp-binary.R

@@ -226,3 +226,19 @@ test_that("binomial mlp case weights", {
    sum(unweighted_pred$.pred_class == "class_2")
  )
 })
+
+test_that('linear activations', {
+ # See https://github.com/tidymodels/brulee/issues/68
+ skip_if(!torch::torch_is_installed())
+ skip_if_not_installed("modeldata")
+
+ data(bivariate, package = "modeldata")
+ set.seed(20)
+ nn_log_biv <-
+  try(
+   brulee_mlp(Class ~ log(A) + log(B), data = bivariate_train,
+              epochs = 150, hidden_units = 3, activation = "linear"),
+   silent = TRUE)
+ expect_s3_class(nn_log_biv, "brulee_mlp")
+
+})