Skip to content

Commit 35c028b

Browse files
authored
Merge pull request #372 from tidymodels/values_weight_func-optimal
Remove `"optimal"` option for `weight_func()`
2 parents 3f3910f + 00434fa commit 35c028b

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515

1616
* The `grid_*()` functions now error instead of warn when provided with the wrong argument to control the grid size. So `grid_space_filling()`, `grid_random()`, `grid_max_entropy()`, and `grid_latin_hypercube()` now error if used with a `levels` argument and `grid_regular()` now errors if used with a `size` argument (#368).
1717

18+
* The `"optimal"` option for the `weight_func()` parameter has been removed since it is choosing the optimal value based on the resubstition error (#370).
19+
1820
* When constructing integer-valued parameters with a range of two consecutive values the `inclusive` argument needs to be set to `c(TRUE, TRUE)` to leave at least two values to sample from (#373).
1921

2022

R/param_weight_func.R

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,5 @@ values_weight_func <- c(
2929
"cos",
3030
"inv",
3131
"gaussian",
32-
"rank",
33-
"optimal"
32+
"rank"
3433
)

man/weight_func.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/testthat/_snaps/constructors.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,9 +205,9 @@
205205
print(fun_ish)
206206
Message
207207
Qualitative Parameter
208-
10 possible values include:
208+
9 possible values include:
209209
'rectangular', 'triangular', 'epanechnikov', 'biweight', 'triweight', 'cos',
210-
'inv', 'gaussian', 'rank', and 'optimal'
210+
'inv', 'gaussian', and 'rank'
211211

212212
---
213213

0 commit comments

Comments
 (0)