update bit64::as.integer64 use in test #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
approved these changes
Dec 31, 2024
|
@hadley @simonpcouch I took another look at this and added some additional commits to try and get everything passing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1564
@simonpcouch @hadley the check is failing for other reasons I believe - it seems that the error "vector memory limit of 16.0 Gb reached, see mem.maxVSize()" on macos came between https://github.com/tidyverse/dbplyr/actions/runs/11802007517/job/32876673073 and https://github.com/tidyverse/dbplyr/actions/runs/12089965184/job/33716160658