clean up .onLoad() #7034
Merged
clean up .onLoad() #7034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.onLoad() seemed to be setting dplyr.show_progress in a users options which didn't seem neccessary. This removes that and maintains current logic (although AFAICT progress bars have been deprecated anyway).
DavisVaughan
force-pushed
the
cleanup-onload
branch
from
d9022f8 to
48a9f2e
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.onLoad() seemed to be setting
dplyr.show_progressin a users options which didn't seem necessary. This removes that and maintains current logic (although AFAICT progress bars have been deprecated anyway).