bind_rows `.id` with `NA` values in names of list

[muschellij2]

Description: If there are NA values in the names of a list, dplyr::bind_rows(.id) and therefore purrr::map_dfr(.id) (though deprecated) have an unusual id column that has no warning/message/error:

values = lapply(1:5, function(x) mtcars)
names(values) = paste0("id_", 1:5)
df = dplyr::bind_rows(values, .id = "id")
unique(df$id)
#> [1] "id_1" "id_2" "id_3" "id_4" "id_5"

names(values)[c(3, 5)] = NA_character_
df = dplyr::bind_rows(values, .id = "id")
unique(df$id)
#> [1] "1" "2" "3" "4" "5"

^{Created on 2024-11-01 with reprex v2.1.1}

Session info

sessioninfo::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value
#>  version  R version 4.4.0 (2024-04-24)
#>  os       macOS Sonoma 14.4.1
#>  system   x86_64, darwin20
#>  ui       X11
#>  language (EN)
#>  collate  en_US.UTF-8
#>  ctype    en_US.UTF-8
#>  tz       America/New_York
#>  date     2024-11-01
#>  pandoc   3.2 @ /Applications/RStudio.app/Contents/Resources/app/quarto/bin/tools/x86_64/ (via rmarkdown)
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version date (UTC) lib source
#>  cli           3.6.3   2024-06-21 [1] CRAN (R 4.4.0)
#>  digest        0.6.37  2024-08-19 [1] CRAN (R 4.4.1)
#>  dplyr         1.1.4   2023-11-17 [1] CRAN (R 4.4.0)
#>  evaluate      1.0.0   2024-09-17 [1] CRAN (R 4.4.1)
#>  fansi         1.0.6   2023-12-08 [1] CRAN (R 4.4.0)
#>  fastmap       1.2.0   2024-05-15 [1] CRAN (R 4.4.0)
#>  fs            1.6.4   2024-04-25 [1] CRAN (R 4.4.0)
#>  generics      0.1.3   2022-07-05 [1] CRAN (R 4.4.0)
#>  glue          1.8.0   2024-09-30 [1] CRAN (R 4.4.1)
#>  htmltools     0.5.8.1 2024-04-04 [1] CRAN (R 4.4.0)
#>  knitr         1.48    2024-07-07 [1] CRAN (R 4.4.0)
#>  lifecycle     1.0.4   2023-11-07 [1] CRAN (R 4.4.0)
#>  magrittr      2.0.3   2022-03-30 [1] CRAN (R 4.4.0)
#>  pillar        1.9.0   2023-03-22 [1] CRAN (R 4.4.0)
#>  pkgconfig     2.0.3   2019-09-22 [1] CRAN (R 4.4.0)
#>  R6            2.5.1   2021-08-19 [1] CRAN (R 4.4.0)
#>  reprex        2.1.1   2024-07-06 [1] CRAN (R 4.4.0)
#>  rlang         1.1.4   2024-06-04 [1] CRAN (R 4.4.0)
#>  rmarkdown     2.28    2024-08-17 [1] CRAN (R 4.4.1)
#>  rstudioapi    0.16.0  2024-03-24 [1] CRAN (R 4.4.0)
#>  sessioninfo   1.2.2   2021-12-06 [1] CRAN (R 4.4.0)
#>  tibble        3.2.1   2023-03-20 [1] CRAN (R 4.4.0)
#>  tidyselect    1.2.1   2024-03-11 [1] CRAN (R 4.4.0)
#>  utf8          1.2.4   2023-10-22 [1] CRAN (R 4.4.0)
#>  vctrs         0.6.5   2023-12-01 [1] CRAN (R 4.4.0)
#>  withr         3.0.0   2024-01-16 [1] CRAN (R 4.4.0)
#>  xfun          0.47    2024-08-17 [1] CRAN (R 4.4.1)
#>  yaml          2.3.10  2024-07-26 [1] CRAN (R 4.4.0)
#> 
#>  [1] /Library/Frameworks/R.framework/Versions/4.4-x86_64/Resources/library
#> 
#> ──────────────────────────────────────────────────────────────────────────────

[DavisVaughan]

This has to do with rlang::is_named() usage

We detect some invalid names, so we replace all of the names with seq_along(dots).

values = lapply(1:5, function(x) mtcars)
names(values) = paste0("id_", 1:5)

rlang::is_named(values)
#> [1] TRUE

names(values)[c(3, 5)] = NA_character_

# Not "validly named" so we replace with `seq_along(dots)`
rlang::is_named(values)
#> [1] FALSE

I imagine the correct behavior may be to only replace invalid names (NA and maybe "") with their index and leave all other names in place.

[DavisVaughan]

This is a possibly slightly more challenging tidy dev day issue, but I think you could make good headway by swapping is_named() for the vectorized variant, which lets you know which names are invalid. And then you'd replace these invalid names with the corresponding index from seq_along(dots)

rlang::have_name(values)
#> [1]  TRUE  TRUE FALSE  TRUE FALSE

So I'd expect the names here to be

"id_1" "id_2" "3" "id_4" "5"

[DavisVaughan]

dplyr/R/bind-rows.R

Lines 65 to 69 in 384ff2c

	check_string(.id)
	if (!is_named(dots)) {
	names(dots) <- seq_along(dots)
	}