Clarified slice_max() and slice_min() in intro vignette # 7671 #7717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubsequent chunks. Clarified wording for slice_max() and slice_min() in the intro vignette
Member
DavisVaughan
left a comment
DavisVaughan
left a comment
There was a problem hiding this comment.
Nice job! A few comments after thinking about this a little more closely
Co-authored-by: Davis Vaughan <[email protected]>
vignettes/dplyr.Rmd
Outdated
Comment on lines
132
to
135
| starwars |> | ||
| filter(!is.na(height)) |> | ||
| slice_max(height, n = 3) | ||
| slice_max(height) |
Member
There was a problem hiding this comment.
@ccani007 something still doesn't look right here. I'm expecting this example to be changed to
starwars |> slice_max(height, n = 3)
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7671
slice_max()andslice_min()in the introduction vignette(explicit default
n = 1, clearer phrasing on NA handling).slice_sample()example code chunk to fix issuesaffecting subsequent chunks.