Switch if_else() to vec_if_else()
#7723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
force-pushed
the
feature/if-else-improvements
branch
from
4c1ae7f to
9862bd8
Compare
DavisVaughan
force-pushed
the
feature/if-else-improvements-2
branch
from
94bc8ae to
3a3603a
Compare
hadley
approved these changes
Sep 30, 2025
Member
Author
|
Revdep results look pretty good here. Only 1-2 failures related to |
DavisVaughan
force-pushed
the
feature/if-else-improvements-2
branch
from
e0691ad to
f94aac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #7722
See r-lib/vctrs#2030 for benchmarks!
One thing of note is that
vec_if_else()disallows arrays forcondition. I am not yet sure if we are going to have to provide a compat layer for 1D arrays inif_else()itself. We will have to run revdeps, and then add a test on the dplyr side if we need this."c6431dd7-a51a-4fe5-81a9-b889d0a1510a"