Skip to content

Conversation

@DavisVaughan
Copy link
Member

@DavisVaughan DavisVaughan commented Oct 10, 2025

In favor of recode_values() and replace_values()

Bringing in dev lifecycle to ensure we don't release dplyr with degraded case_match() performance due to lifecycle::signal_stage().

Updated all case_match() tests to show how to transition to recode_values() and replace_values(), which was very validating

@DavisVaughan DavisVaughan requested a review from hadley October 10, 2025 18:16
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you want to do a lifecycle release soon?

@DavisVaughan
Copy link
Member Author

Do you want to do a lifecycle release soon?

Yes that would be great

@DavisVaughan DavisVaughan merged commit fbae5cf into main Oct 10, 2025
14 checks passed
@DavisVaughan DavisVaughan deleted the feature/deprecate-case-match branch October 10, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants