Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize option interface #264

Open
krlmlr opened this issue Sep 25, 2024 · 5 comments
Open

Finalize option interface #264

krlmlr opened this issue Sep 25, 2024 · 5 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Sep 25, 2024

Support options in addition to (or instead of) env vars.

@krlmlr krlmlr added this to the 1.0.0 milestone Sep 25, 2024
@maelle
Copy link
Collaborator

maelle commented Dec 13, 2024

Actually seeing this, maybe telemetry should not be one file per option as in my PR but instead there could be a duckplyr configuration file? https://blog.r-hub.io/2020/03/12/user-preferences/#using-a-config-file

@maelle
Copy link
Collaborator

maelle commented Dec 13, 2024

This way, all options would be in one place. Maybe it could somehow be created by default, to show the default options.

@maelle
Copy link
Collaborator

maelle commented Dec 13, 2024

The setting of options could happen via functions, or manually.

There could be several locations for the configuration file like for an .Rprofile (user-level vs project-level).

Having it all in one file means it's easier for users to get an overview but probably also for us to document all options somewhere central?

@krlmlr
Copy link
Member Author

krlmlr commented Dec 13, 2024

Yeah, the user interface vs. the actual storage of the options are two separate questions. I'll think about it and work with what's in the PRs.

@krlmlr
Copy link
Member Author

krlmlr commented Jan 24, 2025

Descoping, the env var interface is good enough.

@krlmlr krlmlr removed this from the 1.0.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants