Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upkeep for ggplot2 (2024) #6155

Closed
32 of 37 tasks
teunbrand opened this issue Oct 24, 2024 · 1 comment · Fixed by #6156
Closed
32 of 37 tasks

Upkeep for ggplot2 (2024) #6155

teunbrand opened this issue Oct 24, 2024 · 1 comment · Fixed by #6156
Labels
upkeep maintenance, infrastructure, and similar

Comments

@teunbrand
Copy link
Collaborator

teunbrand commented Oct 24, 2024

To begin

  • pr_init("upkeep-2024-10")

Pre-history

  • usethis::use_readme_rmd()
  • usethis::use_roxygen_md()
  • usethis::use_github_links()
  • usethis::use_pkgdown_github_pages()
  • usethis::use_tidy_github_labels()
  • usethis::use_tidy_style()
  • urlchecker::url_check()

2020

  • usethis::use_package_doc()
  • usethis::use_testthat(3)
  • Align the names of R/ files and test/ files

2021

  • Remove check environments section from cran-comments.md
  • Use lifecycle instead of artisanal deprecation messages

2022

  • Handle and close any still-open master --> main issues
  • usethis:::use_codecov_badge("tidyverse/ggplot2")
  • Update pkgdown site using instructions at https://tidytemplate.tidyverse.org
  • Update lifecycle badges with more accessible SVGs: usethis::use_lifecycle()

2023

  • Update copyright holder in DESCRIPTION: person("Posit Software, PBC", role = c("cph", "fnd"))
  • Run devtools::document() to re-generate package-level help topic with DESCRIPTION changes
  • usethis::use_tidy_logo(); pkgdown::build_favicons(overwrite = TRUE)
  • usethis::use_tidy_coc()
  • Modernize citation files; see updated use_citation()
  • Use pak::pak("tidyverse/ggplot2") in README
  • Consider running usethis::use_tidy_dependencies() and/or replace compat files with use_standalone()
  • Use cli errors or file an issue if you don't have time to do it now
  • usethis::use_standalone("r-lib/rlang", "types-check") instead of home grown argument checkers;
    or file an issue if you don't have time to do it now
  • Add alt-text to pictures, plots, etc; see https://posit.co/blog/knitr-fig-alt/ for examples

2024

To finish

  • usethis::use_mit_license()
  • usethis::use_package("R", "Depends", "4.0")
  • usethis::use_tidy_description()
  • usethis::use_tidy_github_actions()
  • devtools::build_readme()
  • Re-publish released site if needed

Created on 2024-10-24 with usethis::use_tidy_upkeep_issue(), using usethis v3.0.0.9000

@teunbrand teunbrand added the upkeep maintenance, infrastructure, and similar label Oct 24, 2024
@teunbrand
Copy link
Collaborator Author

Why I didn't tick some bullets:

  • usethis::use_readme_rmd()
    • This just initialised an empty readme, which is worse than the current readme
  • usethis::use_pkgdown_github_pages()
    • Current setup seems to work fine
  • usethis::use_tidy_style()
    • Loses some alignments around <- or = operators.
  • Modernize citation files; see updated use_citation()
    • This just initialises an empty citation file, which is worse than the current one. Besides, I don't know what there is to be modernised.
  • Consider running usethis::use_tidy_dependencies() and/or replace compat files with use_standalone()
    • I think we have the dependencies/compat files we need, no need to import spurious ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant