Skip to content

Commit acdf4c0

Browse files
committed
Respond to second CRAN review
1 parent fc1f201 commit acdf4c0

File tree

1 file changed

+27
-1
lines changed

1 file changed

+27
-1
lines changed

Diff for: cran-comments.md

+27-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,33 @@
11
This is a resubmission.
22

33
Original submission: 2018-10-18
4-
CRAN Review: 2019-10-22
4+
First CRAN Review: 2019-10-22
5+
6+
Second submission: 2019-10-22
7+
Second CRAN Review: 2019-10-28
8+
9+
The second reviewer brings up new things:
10+
11+
> Please add small files needed for the examples in the inst/extdata
12+
> subfolder of your package and use system.file() to get the correct
13+
> package path. e.g. sheets_auth_configure.Rd
14+
>
15+
> \dontrun{} should be only used if the example really cannot be executed
16+
> (e.g. because of missing additional software, missing API keys, ...) by
17+
> the user. That's why wrapping examples in \dontrun{} adds the comment
18+
> ("# Not run:") as a warning for the user.
19+
> Does not seem necessary.
20+
> Please replace \dontrun with \donttest.
21+
22+
I have added the requested file, below inst/extdata/, even though it must be
23+
filled with fake data. We cannot ship an actual OAuth client ID and secret
24+
inside a CRAN package this way. As documented for sheets_auth_configure(), the
25+
user has to obtain this JSON for themselves from Google Cloud Platform Console.
26+
But this JSON has valid structure and eliminates a \dontrun{}.
27+
28+
---
29+
30+
Response to the first review:
531

632
The reviewer asked for more details in the description and to explain all acronyms. I have added:
733

0 commit comments

Comments
 (0)