Skip to content

Commit 4a56ae8

Browse files
committed
NEWS and CRAN comments
1 parent fac2557 commit 4a56ae8

File tree

2 files changed

+10
-24
lines changed

2 files changed

+10
-24
lines changed

Diff for: NEWS.md

+6-16
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,12 @@
22

33
# tibble 3.1.1
44

5-
- Same as previous version.
6-
7-
8-
# tibble 3.1.0.9001
9-
105
- `num()` and `char()` are reexported from pillar (#880).
116
- `tribble()` and `frame_matrix()` give an error if values are named (#871, @lorenzwalthert).
127
- Document `cli.num_colors` option (#410).
138
- Fix `new_tibble()` examples for compatibility with pillar 1.6.0.
149

1510

16-
# tibble 3.1.0.9000
17-
18-
- Internal changes only.
19-
20-
2111
# tibble 3.1.0
2212

2313
## Bug fixes
@@ -142,19 +132,19 @@
142132
- Subset assignment ("subassignment") and also subsetting has become stricter. Symptoms:
143133

144134
- Error: No common type for ...
145-
135+
146136
- Error: Assigned data `...` must be compatible with ...
147137

148138
- `i` must have one dimension, not 2
149-
139+
150140
- Error: Lossy cast from ... to ...
151141

152142
The "invariants" article at https://tibble.tidyverse.org/dev/articles/invariants.html describes the invariants that the operations follow in tibble, and the most important differences to data frames. We tried to make subsetting and subassignment as safe as possible, so that errors are caught early on, while introducing as little friction as possible.
153143

154144
- List classes are no longer automatically treated as vectors. Symptoms:
155145

156146
- Error: All columns in a tibble must be vectors
157-
147+
158148
- Error: Expected a vector, not a `...` object
159149

160150
If you implement a class that wraps a list as S3 vector, you need to include `"list"` in the class:
@@ -321,7 +311,7 @@ To improve compatibility with existing code, breaking changes were reduced to a
321311
- `as_tibble.data.frame()` (and also `as_tibble.matrix()`) strip row names by default. Code that relies on tibbles keeping row names now will see:
322312
- a different result when calling `rownames()` or `row.names()`,
323313
- rows full of `NA` values when subsetting rows with with a character vector, e.g. `as_tibble(mtcars)["Mazda RX4", ]`.
324-
314+
325315
Call `pkgconfig::set_config("tibble::rownames", NA)` to revert to the old behavior of keeping row names. Packages that import _tibble_ can call `set_config()` in their `.onLoad()` function (#114).
326316
327317
- `as_tibble()` drops extra classes, in particular `as_tibble.grouped_df()` now removes grouping (#535).
@@ -357,9 +347,9 @@ To improve compatibility with existing code, breaking changes were reduced to a
357347
- `NA`: keep row names,
358348
- A string: the name of the new column that will contain the existing row names,
359349
which are no longer present in the result.
360-
350+
361351
The old default can be restored by calling `pkgconfig::set_config("tibble::rownames", NA)`, this also works for packages that import _tibble_.
362-
352+
363353
- `new_tibble()` and `as_tibble()` now also strip the `"dim"` attribute from columns that are one-dimensional arrays. (`tibble()` already did this before.)
364354

365355
- Internally, all `as_tibble()` implementation forward all extra arguments and `...` to `as_tibble.list()` where they are handled. This means that the common `.rows` and `.name_repair` can be used for all inputs. We suggest that your implementations of this method do the same.

Diff for: cran-comments.md

+4-8
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,11 @@ tibble 3.1.1
77
## R CMD check results
88

99
- [x] Checked locally, R 4.0.5
10-
- [ ] Checked on CI system, R 4.0.5
11-
- [ ] Checked on win-builder, R devel
12-
13-
Check the boxes above after successful execution and remove this line. Then run `fledge::release()`.
10+
- [x] Checked on CI system, R 4.0.5
11+
- [x] Checked on win-builder, R devel
1412

1513
## Current CRAN check results
1614

1715
- [x] Checked on 2021-04-18, problems found: https://cran.r-project.org/web/checks/check_results_tibble.html
18-
- [ ] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64-gcc10-UCRT
19-
- [ ] ERROR: r-devel-windows-ix86+x86_64
20-
21-
Check results at: https://cran.r-project.org/web/checks/check_results_tibble.html
16+
- [x] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64-gcc10-UCRT: LazyData field removed
17+
- [x] ERROR: r-devel-windows-ix86+x86_64: False positive

0 commit comments

Comments
 (0)