Skip to content

Commit cef6ada

Browse files
authored
remove uses_cxx11 call in build_grpc causing macos build failure (#657)
Signed-off-by: Taddes <[email protected]>
1 parent 0b1798d commit cef6ada

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

cross_compile.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ yum install mingw64-openssl-static mingw64-zlib-static mingw64-winpthreads-stati
3232
.define("CMAKE_SYSTEM_PROCESSOR", get_env("CARGO_CFG_TARGET_ARCH").unwrap())
3333
.define("CMAKE_CROSSCOMPILING", "true")
3434
.build_target(library)
35-
.uses_cxx11()
3635
.build()
37-
// config.build_target(library).uses_cxx11().build()
3836
};
3937
```
4038

src/call/client.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,8 +436,7 @@ impl<Req> StreamingCallSink<Req> {
436436
/// `enhance_batch` is enabled, messages will be batched together as many as possible.
437437
/// The rules are listed as below:
438438
/// - All messages except the last one will be sent with `buffer_hint` set to true.
439-
/// - The last message will also be sent with `buffer_hint` set to true unless any message is
440-
/// offered with buffer hint set to false.
439+
/// - The last message will also be sent with `buffer_hint` set to true unless any message is offered with buffer hint set to false.
441440
///
442441
/// No matter `enhance_batch` is true or false, it's recommended to follow the contract of
443442
/// Sink and call `poll_flush` to ensure messages are handled by gRPC C Core.

src/call/server.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -481,8 +481,7 @@ macro_rules! impl_stream_sink {
481481
/// `enhance_batch` is enabled, messages will be batched together as many as possible.
482482
/// The rules are listed as below:
483483
/// - All messages except the last one will be sent with `buffer_hint` set to true.
484-
/// - The last message will also be sent with `buffer_hint` set to true unless any message is
485-
/// offered with buffer hint set to false.
484+
/// - The last message will also be sent with `buffer_hint` set to true unless any message is offered with buffer hint set to false.
486485
///
487486
/// No matter `enhance_batch` is true or false, it's recommended to follow the contract of
488487
/// Sink and call `poll_flush` to ensure messages are handled by gRPC C Core.

src/metadata.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,18 +143,18 @@ impl Clone for MetadataBuilder {
143143
///
144144
/// - Request headers
145145
///
146-
/// They are sent by the client at the beginning of a remote call before
147-
/// any request messages are sent.
146+
/// They are sent by the client at the beginning of a remote call before
147+
/// any request messages are sent.
148148
///
149149
/// - Response headers
150150
///
151-
/// They are sent by the server at the beginning of a remote call handler
152-
/// before any response messages are sent.
151+
/// They are sent by the server at the beginning of a remote call handler
152+
/// before any response messages are sent.
153153
///
154154
/// - Response trailers
155155
///
156-
/// They are sent by the server at the end of a remote call along with
157-
/// resulting call status.
156+
/// They are sent by the server at the end of a remote call along with
157+
/// resulting call status.
158158
///
159159
/// Metadata value can be ascii string or bytes. They are distinguish by the
160160
/// key suffix, key of bytes value should have suffix '-bin'.

0 commit comments

Comments
 (0)