Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VERSION check in configure script to use BRE #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gumnos
Copy link

@Gumnos Gumnos commented Jan 2, 2025

POSIX BRE doesn't support \+ so the grep fails on OpenBSD. Modify the version-check to use proper BRE

Fixes #112

POSIX BRE doesn't support `\+` so the grep fails on OpenBSD. Modify the version-check to use proper BRE
Copy link

ti-chi-bot bot commented Jan 2, 2025

Welcome @Gumnos! It looks like this is your first PR to tikv/jemallocator 🎉

Copy link

ti-chi-bot bot commented Jan 2, 2025

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • e334e21 Update VERSION check in configure script to use BRE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Gumnos
Copy link
Author

Gumnos commented Jan 2, 2025

The link to the CONTRIBUTING.md is broken, so I'm uncertain how to go about updating my commits with the DCO. It's a one-line change.

@sxyazi
Copy link

sxyazi commented Jan 2, 2025

As per https://github.com/tikv/jemallocator/pull/113/checks?check_run_id=35052044761

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

@BusyJay
Copy link
Member

BusyJay commented Jan 6, 2025

Can you also send this PR to https://github.com/jemalloc/jemalloc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version test in configure/configure uses non-BRE regex, triggering failure to match
3 participants