Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all tikv-jemallocator to jemallocator #63

Open
Xuanwo opened this issue Aug 2, 2023 · 4 comments
Open

Replace all tikv-jemallocator to jemallocator #63

Xuanwo opened this issue Aug 2, 2023 · 4 comments

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Aug 2, 2023

Since tikv/jemallocator has become the upstream of jemallocator, I believe it's time to replace all tikv-jemallocator to jemallocator to avoid confusion.

And we should push a new version to tikv-jemallocator with notes that migrate to jemallocator instead.

@BusyJay
Copy link
Member

BusyJay commented Aug 2, 2023

See #56. I'm afraid we have to keep using tikv-jemallocator.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 2, 2023

Hi @gnzlbg, would you like to add either @BusyJay or @tikv/maintainers as a co-owner of the jemallocator-global crate? Thanks in advance.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 2, 2023

There is an another option that merge jemallocator-global features into jemallocator (maybe under a feature flag). jemallocator-global is simple and no extra deps. I'm willing to take this issue if it looks good to you.

@BusyJay
Copy link
Member

BusyJay commented Aug 2, 2023

That might work too. However, we have made the claim in the last release that tikv-jemallocator is preferred than jemallocator for new projects. Changing it back and forth may cause more confusions.

On the other hand, even jemallocator is chosen, we will still need to publish two versions till next minor bump, which is unlikely happen until next jemalloc breaking change is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants