Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure map style in layout xml #86

Open
KyleGW opened this issue Jan 8, 2023 · 1 comment
Open

Add ability to configure map style in layout xml #86

KyleGW opened this issue Jan 8, 2023 · 1 comment
Labels
enhancement New feature or request not-planned Its not quite like wontfix, but no current plans to implement, could change

Comments

@KyleGW
Copy link
Contributor

KyleGW commented Jan 8, 2023

This allows the ability to have different pre-configured styles without having to specify on command line every time.

If done at a widget level it could enable the ability to have two maps on the overlay with different styles. I had an idea to try to make a 'debug' overlay that would have multiple different map styles and zoom levels that I could evaluate what works best for a given video, and then realized the limitation by having it on the command line.

<component type="journey_map" name="journey_map" size="512" corner_radius="35" opacity="0.95" style="osm-bright"/>
<component type="moving_journey_map" name="moving_map" size="512" zoom="17" style="tf-transport-dark"/>
@time4tea
Copy link
Owner

time4tea commented Jan 8, 2023

Hiya - Thanks for the suggestion! - I did try to abstract the map style from the the config on purpose, to avoid making styles in the xml config. This means that a particular xml config can be rendered with any map style. However, I do see that having multiple map styles in a single render could potentially be useful.. but i haven't had a "killer" reason to do that. A "debug" layout isn't quite a strong enough reason, I don't think. If there was a non-debug reason...
Perhaps your debug thing could alternatively be easily scripted externally?
for style in a b c d; do; venv/bin/gopro-dashboard.py --map-style $style...

@time4tea time4tea added enhancement New feature or request not-planned Its not quite like wontfix, but no current plans to implement, could change labels Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not-planned Its not quite like wontfix, but no current plans to implement, could change
Projects
None yet
Development

No branches or pull requests

2 participants