From fdfc42e3e06beda97e67133a0cf20858ac09a9b3 Mon Sep 17 00:00:00 2001
From: max funk <mxfactorial@users.noreply.github.com>
Date: Tue, 2 Jul 2024 13:31:07 -0700
Subject: [PATCH] test for number

---
 .../001_timescaledb_tune.sh                   | 46 ++++++++++---------
 1 file changed, 25 insertions(+), 21 deletions(-)

diff --git a/docker-entrypoint-initdb.d/001_timescaledb_tune.sh b/docker-entrypoint-initdb.d/001_timescaledb_tune.sh
index fdddde1..bb700ba 100755
--- a/docker-entrypoint-initdb.d/001_timescaledb_tune.sh
+++ b/docker-entrypoint-initdb.d/001_timescaledb_tune.sh
@@ -34,28 +34,32 @@ if [ -z "${TS_TUNE_MEMORY:-}" ]; then
         TS_TUNE_MEMORY=$(cat /sys/fs/cgroup/memory/memory.limit_in_bytes)
         TS_CGROUPS_MAX_MEM=true
     fi
-    if [ "${TS_CGROUPS_MAX_MEM:-false}" != "false" ]; then
-        if [ "${TS_TUNE_MEMORY}" = "18446744073709551615" ]; then
-            # Bash seems to error out for numbers greater than signed 64-bit,
-            # so if the value of limit_in_bytes is the 64-bit UNSIGNED max value
-            # we should just bail out and hope timescaledb-tune can figure this
-            # out. If we don't, the next comparison is likely going to fail
-            # or it might store a negative value which will crash later.
-            TS_TUNE_MEMORY=""
-        fi
 
-        FREE_KB=$(grep MemTotal: /proc/meminfo | awk '{print $2}')
-        FREE_BYTES=$(( ${FREE_KB} * 1024 ))
-        if [ ${TS_TUNE_MEMORY} -gt ${FREE_BYTES} ]; then
-            # Something weird is going on if the cgroups memory limit exceeds the total available
-            # amount of system memory reported by "free", which is the total amount of memory available on the host.
-            # Most likely, it is this issue: https://github.com/moby/moby/issues/18087 (if no limit is
-            # set, the max limit is set to the max 64 bit integer). In this case, we just leave
-            # TS_TUNE_MEMORY blank and let timescaledb-tune derive the memory itself using syscalls.
-            TS_TUNE_MEMORY=""
-        else
-            # Convert the bytes to MB so it plays nicely with timescaledb-tune
-            TS_TUNE_MEMORY="$(echo ${TS_TUNE_MEMORY} | awk '{print int($1 / 1024 / 1024)}')MB"
+    # test for numeric TS_TUNE_MEMORY
+    if [[ "${TS_TUNE_MEMORY}" =~ ^[0-9]+$ ]]; then
+        if [ "${TS_CGROUPS_MAX_MEM:-false}" != "false" ]; then
+            if [ "${TS_TUNE_MEMORY}" = "18446744073709551615" ]; then
+                # Bash seems to error out for numbers greater than signed 64-bit,
+                # so if the value of limit_in_bytes is the 64-bit UNSIGNED max value
+                # we should just bail out and hope timescaledb-tune can figure this
+                # out. If we don't, the next comparison is likely going to fail
+                # or it might store a negative value which will crash later.
+                TS_TUNE_MEMORY=""
+            fi
+
+            FREE_KB=$(grep MemTotal: /proc/meminfo | awk '{print $2}')
+            FREE_BYTES=$(( ${FREE_KB} * 1024 ))
+            if [ ${TS_TUNE_MEMORY} -gt ${FREE_BYTES} ]; then
+                # Something weird is going on if the cgroups memory limit exceeds the total available
+                # amount of system memory reported by "free", which is the total amount of memory available on the host.
+                # Most likely, it is this issue: https://github.com/moby/moby/issues/18087 (if no limit is
+                # set, the max limit is set to the max 64 bit integer). In this case, we just leave
+                # TS_TUNE_MEMORY blank and let timescaledb-tune derive the memory itself using syscalls.
+                TS_TUNE_MEMORY=""
+            else
+                # Convert the bytes to MB so it plays nicely with timescaledb-tune
+                TS_TUNE_MEMORY="$(echo ${TS_TUNE_MEMORY} | awk '{print int($1 / 1024 / 1024)}')MB"
+            fi
         fi
     fi
 fi