Skip to content

add e2e program manager test with preconfigured final output addr #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bekauz opened this issue Jan 30, 2025 · 0 comments
Open

add e2e program manager test with preconfigured final output addr #179

bekauz opened this issue Jan 30, 2025 · 0 comments

Comments

@bekauz
Copy link
Contributor

bekauz commented Jan 30, 2025

description

currently we do not have an e2e test configured with a program-manager which sets up libraries with output account addresses that are preconfigured (AccountType::Addr).

specific checks

along with that test, it would be great to validate a few parts of the logic.

AccountInfo is defined as:

pub struct AccountInfo {
    pub name: String,
    pub ty: AccountType,
    pub domain: Domain,
    pub addr: Option<String>,
}

program-manager account configuration loop handles accounts with known addresses as follows:

if let AccountType::Addr { .. } = account.ty {
    warn!("Account with id {} already has an address", account_id);
    continue;
}

feels like this block could perform some sanity checks and general validations of accounts with AccountType::Addr:

  • what if account.ty address does not match the address in account.addr
  • what if account.addr is None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant