Rewrote the plugin

[bhaskarvk]

I'm not creating a PR but I would like you to take a look at my fork

https://github.com/bhaskarvk/leaflet-choropleth

Here's what I've done to it

• Added support for more chroma-js options like bezier interpolate, fix lightness, channel mode
• Rewrote it so that it can work along with omnivore. For now though it requires my fork of omnivore. This allows the plugin to be used not only for GeoJSON but every file that omnivore supports so TopoJSON/KML/GFX/CSV/WKT
• Added ability to customize and add a legend automatically if so desired.

Please let me know what you think, and whether you would be interested in merging this.

[abrin]

Hi, it seems like you did a ton of work, but, I can’t seem to find documentation of how to use the features, examples, or tests for those features, could you point me to them?

Thanks

On Nov 12, 2016, at 5:06 PM, Bhaskar V. Karambelkar notifications@github.com wrote:

I'm not creating a PR but I would like you to take a look at my fork

https://github.com/bhaskarvk/leaflet-choropleth https://github.com/bhaskarvk/leaflet-choropleth
Here's what I've done to it

Added support for more chroma-js options like bezier interpolate, fix lightness, channel mode
Rewrote it so that it can work along with omnivore x-msg://3/mapbox/leaflet-omnivore. For now though it requires my fork of omnivore x-msg://3/bhaskarvk/leaflet-omnivore. This allows the plugin to be used not only for GeoJSON but every file that omnivore supports so TopoJSON/KML/GFX/CSV/WKT
Added ability to customize and add a legend automatically if so desired.
Please let me know what you think, and whether you would be interested in merging this.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #17, or mute the thread https://github.com/notifications/unsubscribe-auth/AALwrmAVGvRwRtl9MX0dMDjDgqxG3T1dks5q9lSMgaJpZM4KwkIq.

[bhaskarvk]

Hi,
I haven't got to that part yet. I did test it out locally, I'll update the examples soon. Thanks!

[abrin]

Cool. I didn't mean to question the work that you did, just without the former, it's really hard to get a handle around the improvements and changes.

[bhaskarvk]

I got caught in some other stuff. I'll revisit this and add proper examples. Thanks for your patience.