Middleware logger makes it difficult to debug

[jacobweinstock]

Currently handlers use ctx.AbortWithError to return errors. The logger in middleware (

hegel/internal/logger/logger.go

Line 14 in d74d351

func Middleware(logger logr.Logger) gin.HandlerFunc {

) then handles logging error messages. This causes all log lines to report the same caller location. hegel/internal/logger/logger.go:53

hegel/internal/logger/logger.go

Line 53 in d74d351

event.Error(errors.New(msg), "all_errors", errs)

This makes debugging challenging and logging of the caller pointless.

Expected Behaviour

Current Behaviour

Possible Solution

One option could be to pass a logger into all handlers. I'm certain there are are others but i'll need to dig into the code and this space mentally a bit more.

Steps to Reproduce (for bugs)

Context

Your Environment

• Operating System and version (e.g. Linux, Windows, MacOS):

• How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

• Link to your project or a code example to reproduce issue: