Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Spec should define a machineRef not a connection #109

Open
jacobweinstock opened this issue May 11, 2023 · 3 comments
Open

Task Spec should define a machineRef not a connection #109

jacobweinstock opened this issue May 11, 2023 · 3 comments

Comments

@jacobweinstock
Copy link
Member

The Task spec currently doesn't allow referencing a machine but requires the full connection details. Tasks should not require the full connection details. It should instead reference a machine like the Job spec does.

Expected Behaviour

Current Behaviour

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

  • Link to your project or a code example to reproduce issue:

@chrisdoherty4
Copy link
Member

This was by design, though I don't recall the details. What's the motivation to change it?

@jacobweinstock
Copy link
Member Author

The UX of jobs is nice. I dont need to add connection details per job. I could see the util in keeping the connection object in a task so that one off tasks can be defined without needing to have a machine CR or before one is created. But once a machine CR exists, having to define the connection details for every tasks is not ideal. Maybe tasks could take either a machine ref or connection details.

@chrisdoherty4
Copy link
Member

chrisdoherty4 commented May 12, 2023

A mutually exclusive field with the connection field sounds quite flexible; I'd probably be in favor of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants